Skip to content

Aspnet Readmes incorrectly lists non-composite tags for composite images #4634

@lbussell

Description

@lbussell

Looking at the Aspnet readmes after composite images were added, the composite row in the table lists 8.0-preview-alpine as a valid tag for these images:

##### .NET 8 Preview Tags
Tags | Dockerfile | OS Version
-----------| -------------| -------------
8.0.0-preview.5-bookworm-slim-amd64, 8.0-preview-bookworm-slim-amd64, 8.0.0-preview.5-bookworm-slim, 8.0-preview-bookworm-slim, 8.0.0-preview.5, 8.0-preview, latest | [Dockerfile](https://github.com/dotnet/dotnet-docker/blob/nightly/src/aspnet/8.0/bookworm-slim/amd64/Dockerfile) | Debian 12
8.0.0-preview.5-alpine3.17-amd64, 8.0-preview-alpine3.17-amd64, 8.0-preview-alpine-amd64, 8.0.0-preview.5-alpine3.17, 8.0-preview-alpine3.17, 8.0-preview-alpine | [Dockerfile](https://github.com/dotnet/dotnet-docker/blob/nightly/src/aspnet/8.0/alpine3.17/amd64/Dockerfile) | Alpine 3.17
8.0.0-preview.5-alpine3.17-composite-amd64, 8.0-preview-alpine3.17-composite-amd64, 8.0-preview-alpine-composite-amd64, 8.0.0-preview.5-alpine3.17, 8.0-preview-alpine3.17, 8.0-preview-alpine | [Dockerfile](https://github.com/dotnet/dotnet-docker/blob/nightly/src/aspnet/8.0/alpine3.17-composite/amd64/Dockerfile) | Alpine 3.17
8.0.0-preview.5-jammy-amd64, 8.0-preview-jammy-amd64, 8.0.0-preview.5-jammy, 8.0-preview-jammy | [Dockerfile](https://github.com/dotnet/dotnet-docker/blob/nightly/src/aspnet/8.0/jammy/amd64/Dockerfile) | Ubuntu 22.04
8.0.0-preview.5-jammy-chiseled-amd64, 8.0-preview-jammy-chiseled-amd64, 8.0.0-preview.5-jammy-chiseled, 8.0-preview-jammy-chiseled | [Dockerfile](https://github.com/dotnet/dotnet-docker/blob/nightly/src/aspnet/8.0/jammy-chiseled/amd64/Dockerfile) | Ubuntu 22.04

However, pulling this tag (on my amd64 machine) always gives me the non-composite image. To fix this we should separate the composite from the non-composite images in the manifest.json, where they are currently grouped under the same shared tags:

dotnet-docker/manifest.json

Lines 3863 to 3964 in 4819bd1

{
"productVersion": "$(dotnet|8.0|product-version)",
"sharedTags": {
"$(dotnet|8.0|product-version)-alpine3.17": {},
"8.0-preview-alpine3.17": {},
"8.0-preview-alpine": {}
},
"platforms": [
{
"buildArgs": {
"REPO": "$(Repo:runtime)"
},
"dockerfile": "src/aspnet/8.0/alpine3.17/amd64",
"dockerfileTemplate": "eng/dockerfile-templates/aspnet/Dockerfile.linux",
"os": "linux",
"osVersion": "alpine3.17",
"tags": {
"$(dotnet|8.0|product-version)-alpine3.17-amd64": {},
"8.0-preview-alpine3.17-amd64": {},
"8.0-preview-alpine-amd64": {}
}
},
{
"architecture": "arm",
"buildArgs": {
"REPO": "$(Repo:runtime)"
},
"dockerfile": "src/aspnet/8.0/alpine3.17/arm32v7",
"dockerfileTemplate": "eng/dockerfile-templates/aspnet/Dockerfile.linux",
"os": "linux",
"osVersion": "alpine3.17",
"tags": {
"$(dotnet|8.0|product-version)-alpine3.17-arm32v7": {},
"8.0-preview-alpine3.17-arm32v7": {},
"8.0-preview-alpine-arm32v7": {}
},
"variant": "v7"
},
{
"architecture": "arm64",
"buildArgs": {
"REPO": "$(Repo:runtime)"
},
"dockerfile": "src/aspnet/8.0/alpine3.17/arm64v8",
"dockerfileTemplate": "eng/dockerfile-templates/aspnet/Dockerfile.linux",
"os": "linux",
"osVersion": "alpine3.17",
"tags": {
"$(dotnet|8.0|product-version)-alpine3.17-arm64v8": {},
"8.0-preview-alpine3.17-arm64v8": {},
"8.0-preview-alpine-arm64v8": {}
},
"variant": "v8"
},
{
"buildArgs": {
"REPO": "$(Repo:runtime-deps)"
},
"dockerfile": "src/aspnet/8.0/alpine3.17-composite/amd64",
"dockerfileTemplate": "eng/dockerfile-templates/aspnet/Dockerfile.linux-composite",
"os": "linux",
"osVersion": "alpine3.17",
"tags": {
"$(dotnet|8.0|product-version)-alpine3.17-composite-amd64": {},
"8.0-preview-alpine3.17-composite-amd64": {},
"8.0-preview-alpine-composite-amd64": {}
}
},
{
"architecture": "arm",
"buildArgs": {
"REPO": "$(Repo:runtime-deps)"
},
"dockerfile": "src/aspnet/8.0/alpine3.17-composite/arm32v7",
"dockerfileTemplate": "eng/dockerfile-templates/aspnet/Dockerfile.linux-composite",
"os": "linux",
"osVersion": "alpine3.17",
"tags": {
"$(dotnet|8.0|product-version)-alpine3.17-composite-arm32v7": {},
"8.0-preview-alpine3.17-composite-arm32v7": {},
"8.0-preview-alpine-composite-arm32v7": {}
},
"variant": "v7"
},
{
"architecture": "arm64",
"buildArgs": {
"REPO": "$(Repo:runtime-deps)"
},
"dockerfile": "src/aspnet/8.0/alpine3.17-composite/arm64v8",
"dockerfileTemplate": "eng/dockerfile-templates/aspnet/Dockerfile.linux-composite",
"os": "linux",
"osVersion": "alpine3.17",
"tags": {
"$(dotnet|8.0|product-version)-alpine3.17-composite-arm64v8": {},
"8.0-preview-alpine3.17-composite-arm64v8": {},
"8.0-preview-alpine-composite-arm64v8": {}
},
"variant": "v8"
}
]
},

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-dockerfilesConcerns the official .NET Dockerfiles or Dockerfile templates

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions