Add arm mariner build images #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthalman
approved these changes
Mar 31, 2023
|
Looks like downloading the headers won't be necessary with dotnet/runtime#84207. Thanks @am11! |
sbomer
changed the title
|
@sbomer, thanks. I was thinking about NativeAOT static executable use-case, where we have option to link libnuma statically in the binary. The license of libnuma is LGPL 2.1, which restricts linking code with differently-licensed apps. Even using its headers could be problematic as wordings in license look a bit vague. Above all, our usage was pretty simple (like cgroup, for which we don't use any lib either), so I ended up simplifying the support instead. FYI: @ayakael, .NET 8+ build machines won't be needing libnuma anymore (after dotnet/runtime#84207). |
|
@mthalman please merge when you have a chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the arm images which were left out of #832.
They include logic to download the numa headers, working around packages that didn't exist for arm in Ubuntu 16.04 or Alpine 3.13.See dotnet/arcade#12144 for context on why we need the numa headers installed.
Contributes to dotnet/runtime#83428
@janvorli @am11 @mthalman PTAL