Adding V8 engine to webassembly container in order to run trimming tests #409
Conversation
|
|
||
| # Install V8 Engine to be able to execute Trimming Tests | ||
| RUN curl -sL https://deb.nodesource.com/setup_12.x | bash - \ | ||
| && apt install -y nodejs \ |
There was a problem hiding this comment.
Installing nodejs shouldn't be necessary. It's already installed in the base image at
There was a problem hiding this comment.
True but for v8 engine we will need npm 10+ which will only be available after the previouse curl command. After running that, the apt install nodejs will install the new npm which will be able to install the v8 engine. With the nodejs that is preinstalled in the container we can't install v8.
There was a problem hiding this comment.
@joperezr we don't need to install v8 from npm/jsvu, for the helix queue we just download the binary from blob storage: https://dev.azure.com/dnceng/internal/_git/dotnet-helix-machines?path=%2Fartifacts%2Flinux-v8-engine%2Flinux-v8-engine.sh&_a=contents&version=GBmaster
cc: @safern @mthalman @akoeplinger @MichaelSimons
Contributes to dotnet/runtime#39274
dotnet/runtime trimming tests are executing during build-time (not executed in Helix) and today we are not running them on the wasm vertical due to the fact that our webassembly build container doesn't have v8 installed in order to be able to execute webassmebly app bundles. This PR will add the v8 engine to the webassembly container, and a subsequent PR in dotnet/runtime will use this new container to add a wasm leg for our trimming tests.