Update node in 8.0 webassembly image #1344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still trying to unblock dotnet/runtime#110199
steveisok
approved these changes
Feb 6, 2025
sbomer
approved these changes
Feb 6, 2025
|
@akoeplinger - This now introduced a vulnerability in the image: https://github.com/dotnet/dotnet-buildtools-prereqs-docker-internal/issues/411 |
|
@mthalman that one should actually be fixed by this change, I checked and the semver package in node 16.0 is not vulnerable. The finding is likely from the earlier node. |
|
You're right. My bad. This is from the previous version of the image. |
|
No worries, thanks for keeping an eye on it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still trying to unblock dotnet/runtime#110199