Skip to content

Conversation

@ellahathaway
Copy link
Member

@ellahathaway ellahathaway commented Aug 1, 2024

Closes #1148

This PR assigns an owner to each dockerfile in the repo & adds PR validation to check that each dockerfile has an owner. The idea is to ping the owner of the file (if a team) or assign the owner to the issue (if an individual).

I did assignments based on git history and the information I received from asking folks which files they own. I had to guess on the ownership of some of the files based on the git history.

We may need to assign write access to the repo for those in the codeowners file with red/error lines.

Here is a link to a sample PR where I tested the validation. This is an example of passing validation and this is an example of failing validation.

NOTE: I don't see the "Actions" tab in this repo, so we may have to enable it for this repo: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository

@ellahathaway ellahathaway force-pushed the ownership-validation branch from 8cd2bc8 to 8f732b5 Compare August 5, 2024 23:39
@ellahathaway ellahathaway requested a review from mthalman August 6, 2024 18:46
@ellahathaway
Copy link
Member Author

The build failure seems unrelated - filed #1160 in response.

@mthalman mthalman disabled auto-merge August 7, 2024 13:01
@mthalman mthalman merged commit 2abed36 into dotnet:main Aug 7, 2024
@MichaelSimons
Copy link
Member

@ellahathaway - would you mind updating the How to modify or create a new image section of the readme to explain that a team code owner must be defined for each Dockerfile and what the responsibilities are? TIA

@ellahathaway ellahathaway deleted the ownership-validation branch August 7, 2024 15:50
@ellahathaway
Copy link
Member Author

would you mind updating the How to modify or create a new image section of the readme to explain that a team code owner must be defined for each Dockerfile and what the responsibilities are? TIA

Addressed in #1161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Define owner(s) for each Dockerfile

4 participants