Skip to content

Conversation

@rzikm
Copy link
Member

@rzikm rzikm commented Sep 18, 2023

Add comments for new MediaTypeNames members.

Contributes to dotnet/runtime#88569.

Exported from dotnet/runtime#92220, don't merge before this one.

@rzikm rzikm requested a review from a team as a code owner September 18, 2023 14:09
@ghost ghost assigned rzikm Sep 18, 2023
@ghost ghost added the area-System.Net label Sep 18, 2023
@ghost
Copy link

ghost commented Sep 18, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Add comments for new MediaTypeNames members.

Contributes to dotnet/runtime#88569.

Author: rzikm
Assignees: rzikm
Labels:

area-System.Net

Milestone: -

@learn-build-service-prod
Copy link

Learn Build status updates of commit 59031fb:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Mime/MediaTypeNames+Application.xml ✅Succeeded View
xml/System.Net.Mime/MediaTypeNames+Font.xml ✅Succeeded View
xml/System.Net.Mime/MediaTypeNames+Image.xml ✅Succeeded View
xml/System.Net.Mime/MediaTypeNames+Multipart.xml ✅Succeeded View
xml/System.Net.Mime/MediaTypeNames+Text.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@antonfirsov
Copy link
Contributor

Exported from dotnet/runtime#92220, don't merge before this one.

@rzikm ultimately the source of truth is the dotnet-api-docs repo, so we don't have to worry about the order.

Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlossanlop carlossanlop merged commit 7f50e2f into dotnet:main Sep 18, 2023
@rzikm
Copy link
Member Author

rzikm commented Sep 19, 2023

Exported from dotnet/runtime#92220, don't merge before this one.

@rzikm ultimately the source of truth is the dotnet-api-docs repo, so we don't have to worry about the order.

Well, yes, but there were some unresolved comments on the other PR so I wanted to wait to see if there are not some changes to be carried over to this one

@antonfirsov
Copy link
Contributor

Opened #9314.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants