Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some missing PNSEs #7024

Merged
merged 4 commits into from
Aug 11, 2021
Merged

Add some missing PNSEs #7024

merged 4 commits into from
Aug 11, 2021

Conversation

buyaa-n
Copy link
Contributor

@buyaa-n buyaa-n commented Aug 10, 2021

Summary

Related to #1683 and dotnet/runtime#47228

Adding a few missing PNSEs for some CodeDom APIs not supported in .Net Core. This API might get supported in the future but for now, has no progress.

The RsaProtectedConfigurationProvider type is not supported on .Net Core and all APIs throws but it has an open PR which will not be merged into 6.0. For this type did not added PNSE for all APIs, instead added a note on the type

@opbld31
Copy link

opbld31 commented Aug 10, 2021

Docs Build status updates of commit 4835c21:

✅ Validation status: passed

File Status Preview URL Details
xml/System.CodeDom.Compiler/CodeDomProvider.xml ✅Succeeded View
xml/System.Configuration/RsaProtectedConfigurationProvider.xml ✅Succeeded View
xml/System.Text.RegularExpressions/Regex.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld31
Copy link

opbld31 commented Aug 11, 2021

Docs Build status updates of commit 7368e44:

✅ Validation status: passed

File Status Preview URL Details
xml/System.CodeDom.Compiler/CodeDomProvider.xml ✅Succeeded View
xml/System.Configuration/RsaProtectedConfigurationProvider.xml ✅Succeeded View
xml/System.Text.RegularExpressions/Regex.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Member

@jeffhandley jeffhandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending the guidance from @gewarren on the right phrase for ".NET Core and .NET 5" (and/or the posted suggestion applied to all locations), approved.

xml/System.CodeDom.Compiler/CodeDomProvider.xml Outdated Show resolved Hide resolved
xml/System.CodeDom.Compiler/CodeDomProvider.xml Outdated Show resolved Hide resolved
xml/System.CodeDom.Compiler/CodeDomProvider.xml Outdated Show resolved Hide resolved
xml/System.CodeDom.Compiler/CodeDomProvider.xml Outdated Show resolved Hide resolved
xml/System.Text.RegularExpressions/Regex.xml Outdated Show resolved Hide resolved
Co-authored-by: Jeff Handley <[email protected]>
Co-authored-by: Genevieve Warren <[email protected]>
@opbld33
Copy link

opbld33 commented Aug 11, 2021

Docs Build status updates of commit 7ac1375:

✅ Validation status: passed

File Status Preview URL Details
xml/System.CodeDom.Compiler/CodeDomProvider.xml ✅Succeeded View
xml/System.Configuration/RsaProtectedConfigurationProvider.xml ✅Succeeded View
xml/System.Text.RegularExpressions/Regex.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld30
Copy link

opbld30 commented Aug 11, 2021

Docs Build status updates of commit 9e15c41:

✅ Validation status: passed

File Status Preview URL Details
xml/System.CodeDom.Compiler/CodeDomProvider.xml ✅Succeeded View
xml/System.Configuration/RsaProtectedConfigurationProvider.xml ✅Succeeded View
xml/System.Text.RegularExpressions/Regex.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@buyaa-n
Copy link
Contributor Author

buyaa-n commented Aug 11, 2021

Thanks for the review

@buyaa-n buyaa-n merged commit c5143e4 into dotnet:main Aug 11, 2021
@buyaa-n buyaa-n deleted the pnse_apis branch August 11, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants