Skip to content

Conversation

@gewarren
Copy link
Contributor

@gewarren gewarren commented Jan 19, 2025

From UUF feedback: "In the code example of "The Dispose(bool) method overload", he placement of this comment doesn't match the description text below the code sample:// TODO: set large fields to null. According the the textual description, this TODO should be inside the if block above."


Internal previews

📄 File 🔗 Preview link
docs/standard/garbage-collection/implementing-dispose.md Implement a Dispose method

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

I had one question (duplicate), and then let's :shipit:

@gewarren gewarren enabled auto-merge (squash) January 21, 2025 20:27
@gewarren gewarren merged commit 9d498cf into dotnet:main Jan 21, 2025
8 checks passed
@gewarren gewarren added the user-feedback Issues related to "Unified User Feedback". label Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dotnet-fundamentals/svc user-feedback Issues related to "Unified User Feedback".

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants