Skip to content

Fix: Update F# Recursive Namespace Example for Improved Clarity and Consistency #44275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2025
Merged

Fix: Update F# Recursive Namespace Example for Improved Clarity and Consistency #44275

merged 1 commit into from
Jan 16, 2025

Conversation

@shethaadit
Copy link
Contributor

@shethaadit shethaadit commented Jan 14, 2025 •
edited
Loading

Summary

  • Updated the parameter name in let peel to banana for improved clarity.
  • Enhanced comments to better explain function responsibilities and dependencies.
  • Preserved the overall structure and functionality of the code.

Fixes #44181

Internal previews

📄 File 🔗 Preview link
docs/fsharp/language-reference/namespaces.md Namespaces (F#)

@dotnetrepoman dotnetrepoman bot added this to the January 2025 milestone Jan 14, 2025
@dotnet-policy-service dotnet-policy-service bot added dotnet-fsharp/svc community-contribution Indicates PR is created by someone from the .NET community. labels Jan 14, 2025
psfinaki
psfinaki reviewed Jan 14, 2025
View reviewed changes
BillWagner
BillWagner approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM as well. I'll :shipit: now.

@BillWagner BillWagner merged commit 1fe1a44 into dotnet:main Jan 16, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagner BillWagner BillWagner approved these changes

@KathleenDollard KathleenDollard Awaiting requested review from KathleenDollard

+1 more reviewer

@psfinaki psfinaki psfinaki left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

community-contribution Indicates PR is created by someone from the .NET community. dotnet-fsharp/svc

Projects

None yet

Milestone

January 2025

Development

Successfully merging this pull request may close these issues.

3 participants

@shethaadit @BillWagner @psfinaki