Skip to content

Conversation

@antonfirsov
Copy link
Contributor

@antonfirsov antonfirsov commented Dec 5, 2024

.NET 9 introduced additions to System.Net distributed tracing which define a contract following OTel recommendations:

This PR documents the activities together with their attributes in a manner similar to the metrics docs added by #37213. The matching semconv PR is open-telemetry/semantic-conventions#1192. Conceptual docs are being introduced in #42830.

Moreover, the PR also adjusts certain parts of the metrics doc in order to make it more accurate, synchronize it with the activities doc and incorporate the changes from #42810.


Internal previews

📄 File 🔗 Preview link
docs/core/diagnostics/built-in-metrics-system-net.md System.Net metrics
docs/core/diagnostics/distributed-tracing-builtin-activities.md Built-in Activities in .NET
docs/core/diagnostics/distributed-tracing-concepts.md .NET distributed tracing concepts
docs/core/diagnostics/distributed-tracing.md docs/core/diagnostics/distributed-tracing
docs/navigate/tools-diagnostics/toc.yml docs/navigate/tools-diagnostics/toc

@antonfirsov antonfirsov requested review from a team and tommcdon as code owners December 5, 2024 15:58
@dotnetrepoman dotnetrepoman bot added this to the December 2024 milestone Dec 5, 2024
Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe @MihaZupan can help looking too to validate the details.

Co-authored-by: Genevieve Warren <[email protected]>
Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

@antonfirsov antonfirsov merged commit 238a11d into dotnet:main Dec 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants