[diagnostics] Add InstrumentAdvice details to instrumentation doc #43640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
tarekgh
reviewed
Nov 19, 2024
tarekgh
reviewed
Nov 19, 2024
cijothomas
reviewed
Nov 19, 2024
cijothomas
reviewed
Nov 19, 2024
cijothomas
reviewed
Nov 19, 2024
tarekgh
approved these changes
Nov 19, 2024
noahfalk
reviewed
Nov 19, 2024
noahfalk
approved these changes
Nov 19, 2024
Member
noahfalk
left a comment
noahfalk
left a comment
There was a problem hiding this comment.
This looked good to me overall. A few suggestions inline.
cijothomas
reviewed
Nov 20, 2024
cijothomas
reviewed
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add content + example showing the System.Diagnostics.DiagnosticSource v9.0.0 InstrumentAdvice API.
The goal is to link to this from the OTel .NET docs: https://github.com/open-telemetry/opentelemetry-dotnet/blob/e3665c95c21082f5675cb4d5863051201f640397/docs/metrics/customizing-the-sdk/README.md?plain=1#L244-L252
Internal previews