-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main into live #36469
Merged
Merged
Merge main into live #36469
Commits on Jul 31, 2023
-
Update coding guidelines (#36428)
* rearrange content Make the new content organization follow better ordering. * rewrite and update Rewrite to match the docs team's accepted style. * Edits to fix `var` issues Fixes #26787: clarify "obvious" Fixes #32633: add explanation, update variable names. Fixes #34940: Explain that `var` is preferred in LINQ queries, despite other rules. * Fix naming conventions Fixes #30626: Clarify (again) that these are our guidelines, not yours. Point out that it's not the VS default, but a configuration option. Fixes #30642: Again, our style. Fixes #30799: Change constant style from ALL_CAPS to PascalCase to match runtime repo. Fixes #33959: Update variable names so delegate types are PascalCased and instances of a delegate are camelCase. Add clarifying text for the same. * Fix exception example Fixes #31951 : Rewrite the exception example so that it's still obvious what can fail, but couldn't be easily anticipated before making the computation. * Fixes #30897 Move the Generic type parameter naming conventions to the general naming conventions. * Fix build warnings * Reference runtime convention The use of `_` and `s_` follow the runtime conventions. I'd missed that in the previous commit. * Apply suggestions from code review Co-authored-by: David Pine <[email protected]> --------- Co-authored-by: David Pine <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 49d553f - Browse repository at this point
Copy the full SHA 49d553fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 183f2ec - Browse repository at this point
Copy the full SHA 183f2ecView commit details -
Make actions and funcs local (#36458)
See #36428 (comment) For the issue involved, it's a better fix to create local variables for the Func and Action objects. That shows readers the distinction between the delegate type and the instance.
Configuration menu - View commit details
-
Copy full SHA for fd56aa8 - Browse repository at this point
Copy the full SHA fd56aa8View commit details -
Configuration menu - View commit details
-
Copy full SHA for b155ced - Browse repository at this point
Copy the full SHA b155cedView commit details -
Configuration menu - View commit details
-
Copy full SHA for 29438dc - Browse repository at this point
Copy the full SHA 29438dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 99633b7 - Browse repository at this point
Copy the full SHA 99633b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 52882a7 - Browse repository at this point
Copy the full SHA 52882a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for a92a088 - Browse repository at this point
Copy the full SHA a92a088View commit details -
Configuration menu - View commit details
-
Copy full SHA for 197f228 - Browse repository at this point
Copy the full SHA 197f228View commit details -
Update prepare-libraries-for-trimming.md (#36414)
* Update prepare-libraries-for-trimming.md Update to .NET 8 * Update prepare-libraries-for-trimming.md * Update prepare-libraries-for-trimming.md Remove horizontal scroll bar on tablets * Update prepare-libraries-for-trimming.md
Configuration menu - View commit details
-
Copy full SHA for 8e4994f - Browse repository at this point
Copy the full SHA 8e4994fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b1bd2c - Browse repository at this point
Copy the full SHA 0b1bd2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for a6f103c - Browse repository at this point
Copy the full SHA a6f103cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.