Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document NET 7 breaking changes for workloads and RID inference #32784

Closed
wants to merge 2 commits into from

Conversation

nagilson
Copy link
Member

The additional information for the changes is included in the doc change itself. We didn't expect RID Inference to be a breaking change but there were after-effects, like here: dotnet/sdk#29164 or here dotnet/sdk#29177

The additional information is included above. We didn't expect RID Inference to be a breaking change but there were after-effects, like here: dotnet/sdk#29164 or here dotnet/sdk#29177
@dotnet-bot dotnet-bot added this to the November 2022 milestone Nov 29, 2022
@nagilson nagilson added 🏁 Release: .NET 7 Work items for the .NET 7 release breaking-change Indicates a .NET Core breaking change labels Nov 29, 2022
@@ -123,6 +123,8 @@ If you're migrating an app to .NET 7, the breaking changes listed here might aff
| [MSBuild serialization of custom types in .NET 7](sdk/7.0/custom-serialization.md) | ❌ | ❌ | 7.0.100 |
| [dotnet test: switch `-a` to alias `--arch` instead of `--test-adapter-path`](https://github.com/dotnet/sdk/issues/21389) | ❌ | ❌ | Preview 1 |
| [dotnet test: switch `-r` to alias `--runtime` instead of `--results-dir`](https://github.com/dotnet/sdk/issues/21952) | ❌ | ❌ | Preview 1 |
| [Preview .NET 7 SDK installation workloads can interfere with RTM workloads](https://github.com/dotnet/core/blob/main/release-notes/7.0/known-issues.md#70-projects-using-certain-workloads-dont-load-build-and-or-run-if-net-7-preview-sdk-workloads-are-installed) |✔️ | ✔️ | Preview 3 |
Copy link
Contributor

@gewarren gewarren Nov 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PriyaPurkayastha Can you take a look at this pattern of just including the breaking change in the overview doc for breaking changes and then linking to a dotnet/sdk or dotnet/core issue for the details?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, I just noticed at the same time that previously in net 6 there were individual doc pages for each change. That seems better.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nagilson The established process for .NET breaking changes is to open an issue using the breaking change issue template, and then someone from the docs team (me) transcribes that into a doc: https://github.com/dotnet/docs/issues/new?assignees=gewarren&labels=breaking-change%2CPri1%2Cdoc-idea&template=breaking-change.yml&title=%5BBreaking+change%5D%3A+

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing me to that. I can go fill that out... there is another breaking change we will likely make in 7.0.200 as well, anywho

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will close this since there are now 2 issues filled out using the template. As for the other breaking change, it hasn't been merged yet, and we may be able to circumvent it, so I won't make that one for now.

@nagilson nagilson closed this Dec 1, 2022
@gewarren gewarren deleted the nagilson-breaking-changes-7-update branch May 22, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Indicates a .NET Core breaking change 🏁 Release: .NET 7 Work items for the .NET 7 release dotnet-fundamentals/svc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants