Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supported collection types doc for System.Text.Json #22217

Merged
merged 16 commits into from
Jan 6, 2021
Merged

Supported collection types doc for System.Text.Json #22217

merged 16 commits into from
Jan 6, 2021

Conversation

tdykstra
Copy link
Contributor

@tdykstra tdykstra commented Jan 4, 2021 •
edited
Loading

@tdykstra tdykstra requested a review from a team as a code owner January 4, 2021 18:38
@tdykstra tdykstra requested a review from layomia January 4, 2021 18:43
@tdykstra tdykstra requested review from gewarren and removed request for layomia January 5, 2021 22:44
gewarren
gewarren approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple final suggestions.

docs/standard/serialization/system-text-json-supported-collection-types.md Show resolved Hide resolved
docs/standard/serialization/system-text-json-supported-collection-types.md Outdated Show resolved Hide resolved
docs/standard/serialization/system-text-json-supported-collection-types.md Outdated Show resolved Hide resolved
@tdykstra @gewarren
Apply suggestions from code review
1862cd3 
Co-authored-by: Genevieve Warren <[email protected]>
@tdykstra
Copy link
Contributor Author

tdykstra commented Jan 5, 2021

Thanks for the review @gewarren!

@tdykstra tdykstra requested a review from jozkee January 5, 2021 23:45
gewarren
gewarren reviewed Jan 5, 2021
View reviewed changes
docs/standard/serialization/system-text-json-supported-collection-types.md

::: zone-end

\* See [Support round trip for Stack\<T>](system-text-json-converters-how-to.md#support-round-trip-for-stackt).
Copy link
Contributor

@gewarren gewarren Jan 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't indent properly, I guess because it's separated from the zone. You might add is separately to each zone so it 1) is indented and 2) appears before the double asterisk.

https://review.docs.microsoft.com/en-us/dotnet/standard/serialization/system-text-json-supported-collection-types?branch=pr-en-us-22217&pivots=dotnet-core-3-1#custom-collections-with-deserialization-support

@tdykstra tdykstra merged commit b060116 into dotnet:master Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren approved these changes

@jozkee jozkee Awaiting requested review from jozkee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add supported types article to System.Text.Json documentation
2 participants
@tdykstra @gewarren