Issue 18496 #21677
Merged
Issue 18496 #21677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mfcallahan, thank you for submitting this PR. It would be better if we update the reference application |
Contributor
Author
|
@sughosneo Thanks, I will submit a pull request for the eShopOnContainers repo. |
This was referenced Nov 25, 2020
Contributor
Author
|
@sughosneo Issue 1527 and created and pull request created for eShopOnContainers repo. |
thank you @mfcallahan , will test and update. |
IEvangelist
reviewed
Dec 14, 2020
Member
IEvangelist
left a comment
IEvangelist
left a comment
There was a problem hiding this comment.
A few bits of C# clean up
...itecture/microservices/microservice-ddd-cqrs-patterns/enumeration-classes-over-enum-types.md
Outdated
Show resolved
Hide resolved
...itecture/microservices/microservice-ddd-cqrs-patterns/enumeration-classes-over-enum-types.md
Outdated
Show resolved
Hide resolved
IEvangelist
approved these changes
Dec 17, 2020
Member
IEvangelist
left a comment
IEvangelist
left a comment
There was a problem hiding this comment.
Looks good to me, we'll 
- thank you 🙏
BillWagner
added
dotnet-architecture/svc
microservices/subsvc
and removed
📚 Area - .NET Architecture Guide
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes per original issue and discussion:
nameofexpressionFixes #18496