Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

Deployment scenarios with k8s#583

Merged
IEvangelist merged 5 commits intodotnet:preview-5from
IEvangelist:deployment-scenarios
Apr 4, 2024
Merged

Deployment scenarios with k8s#583
IEvangelist merged 5 commits intodotnet:preview-5from
IEvangelist:deployment-scenarios

Conversation

@IEvangelist
Copy link
Copy Markdown
Member

@IEvangelist IEvangelist commented Apr 3, 2024

Summary

Deployment scenarios with k8s.

Fixes #546


Internal previews

📄 File 🔗 Preview link
docs/deployment/overview.md .NET Aspire deployments

@IEvangelist IEvangelist requested a review from tdykstra April 3, 2024 15:12
@dotnet-bot dotnet-bot added the deployment Content related to deployment. label Apr 3, 2024
IEvangelist and others added 3 commits April 3, 2024 10:20
* Initial bits for hosting changes. Fixes dotnet#535

* Clean up list and text

* Updated, let's go
@IEvangelist IEvangelist force-pushed the deployment-scenarios branch from 308b463 to 625528b Compare April 3, 2024 15:22
Copy link
Copy Markdown
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few nit suggestions.

Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
@claudiaregio
Copy link
Copy Markdown

@IEvangelist Aspir8 content seems reasonable to me but might be worth having @glennc, @bradygaster, or @DamianEdwards sign off on that part. Minor nit -> "There's an open-source project named.." didn't feel very formal for docs. I would maybe expect to see something like "Aspir8, an open-source project, handles the generation..."

My question was around the Kubernetes manifests section -> It felt a bit odd to only direct visitors to a learn module. Would it be worth having some instructions that would let experienced folks get moving and then have some way to say "if you're completely new to this we recommend the learn module"?

@IEvangelist
Copy link
Copy Markdown
Member Author

Aspir8, an open-source project, handles the generation

I'll update the first section as suggested, as for the manual part - happy to update it, but we literally don't have content on it anywhere else. That's all I was able to find, if we want to include any sort of bulleted list items, what are those steps?

@claudiaregio
Copy link
Copy Markdown

claudiaregio commented Apr 3, 2024

Aspir8, an open-source project, handles the generation

I'll update the first section as suggested, as for the manual part - happy to update it, but we literally don't have content on it anywhere else. That's all I was able to find, if we want to include any sort of bulleted list items, what are those steps?

@glennc @bradygaster Are there specific steps worth mentioning on these docs? Or is pointing to the learn module fine

@IEvangelist IEvangelist merged commit 67efe4c into dotnet:preview-5 Apr 4, 2024
IEvangelist added a commit that referenced this pull request Apr 9, 2024
* Add diagnostics overview page (#543)

* Fix #521

* Try fixing xref

* Add placeholder for preview-5 what's new (#558)

* Add details about hosting components. (#559)

* Add details about hosting components. Fixes #538

* Clean up description

* Feedback

* Fix warnings

* Fix text, packages over components for hosting

* Add new article to fix #551 (#562)

* Add new article to fix #551

* fix tabs and correct text

* Change from plaintext to output

* Change alert

* Update preview-5.md

* Update preview-5.md

* Add healthz details (#563)

* Add healthz details

* Touch date

* Upgrade node-version

* Sync with main

* Fix MD lint issues

* Added a section about custom service defaults (#560)

* Update SD content, fixes #549

* Highlight dependency and add link/alert

* Remove AddBuiltInMeters() (#518)

Update the documentation to use built-in OpenTelemetry instrumentation.

* Try sync with source (#570)

* Update preview-5.md

* Added a few bits about templates (#572)

* Added a few bits about templates

* Fix more MD lint issues

* Initial bits for hosting changes. (#561)

* Initial bits for hosting changes. Fixes #535

* Clean up list and text

* Updated, let's go

* Deployment scenarios with k8s (#583)

* Try sync with source (#570)

* Initial bits for hosting changes. (#561)

* Initial bits for hosting changes. Fixes #535

* Clean up list and text

* Updated, let's go

* Add k8s content

* Apply suggestions from code review

Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>

* Apply suggestions from code review

---------

Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>

* Add seq component (#584)

* Add seq component

* fixes

* link fix

* Apply suggestions from code review

Co-authored-by: David Pine <david.pine@microsoft.com>

---------

Co-authored-by: David Pine <david.pine@microsoft.com>

* Nats component (#586)

* Add NATS component

* lint fixes

* fixes

* fix links

* fix toc

* Add Azure Event Hubs component + (#587)

* Many fixes

* touch dates.

* Add to TOC

* Remove from TOC

* Update component section of preview5.

* Correct package as Azure AI hosting

* Add missing PostgreSQL hosting package

* Clean up custom impl of service defaults

* Initial content for preview 5. (#588)

* Initial effort for local provisioning (#589)

* Initial effort for local provisioning

* TOC

* Images and lightbow

* Fix rendering issue

* Tweak lightbox

* Reposition article in TOC

* Update docs/deployment/azure/local-provisioning.md

Co-authored-by: David Fowler <davidfowl@gmail.com>

* Remove zones

* A bit of clean up for preview-5

* Move NATs

* A few fixes

* Fix image

---------

Co-authored-by: David Fowler <davidfowl@gmail.com>

* added tooling features

* A few bits of cleanup

* Added note about upgrade assistant tooling

* More P5 updates across Azure, AppModel and manifest. (#596)

* More P5 updates across Azure, AppModel and manifest.

* Apply suggestions from code review

* Apply suggestions from code review

---------

Co-authored-by: David Pine <david.pine.7@gmail.com>

* Another major edit pass, with several more to go

* Add link

* A few more bits of cleanup

* Add link to templates

* Fix xUnit template description

* Another edit pass

* Add link to upgrade with assitant

* Remove .NET Core naming

* For more info

* Update docs/fundamentals/setup-tooling.md

Co-authored-by: Aditya Mandaleeka <adityamandaleeka@users.noreply.github.com>

* Fixed headings affecting TOC

* Remove IDE protocol ending

* Making dashboard auth be explicit on the config auth name

* Dashboard section update

* Dash

* Update

* Update

* Update

* Apply suggestions from code review

* Update preview-5.md

* Fix docker command

* Add with external endpoint API

* Fix non-nuget link warnings, and other CI issues

* Fix last absolute link warning

* Add ASPIRE_ALLOW_UNSECURED_TRANSPORT details

* Minor tweaks

* Typo

* Apply suggestions from code review

Co-authored-by: David Fowler <davidfowl@gmail.com>

* Touch

* Add AWS bits

* Correct link

---------

Co-authored-by: David Fowler <davidfowl@gmail.com>
Co-authored-by: Martin Costello <martin@martincostello.com>
Co-authored-by: kvenkatrajan <102772054+kvenkatrajan@users.noreply.github.com>
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
Co-authored-by: alexwolfmsft <93200798+alexwolfmsft@users.noreply.github.com>
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Co-authored-by: Mitch Denny <midenn@microsoft.com>
Co-authored-by: bradygaster <bradyg@microsoft.com>
Co-authored-by: Tim Heuer <tim@timheuer.com>
Co-authored-by: Aditya Mandaleeka <adityamandaleeka@users.noreply.github.com>
Co-authored-by: James Newton-King <james@newtonking.com>
@bradygaster
Copy link
Copy Markdown
Member

@IEvangelist i was thinking about the page we have on deploying to container apps, the tab view? I think this page would pop more if we had a similar approach. Maybe the tabs would say "Deployment scenarios" and you'd have "AZD to ACA," "Kubernetes," and so on.

@IEvangelist IEvangelist deleted the deployment-scenarios branch May 1, 2024 19:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

deployment Content related to deployment.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants