Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deno hosting documentation #1896

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

brian-guerrero
Copy link

@brian-guerrero brian-guerrero commented Oct 25, 2024

Summary

Adds documentation for .NET Aspire Community Toolkit Deno package.

Fixes #1889


Internal previews

📄 File 🔗 Preview link
docs/community-toolkit/hosting-deno.md .NET Aspire Community Toolkit Deno hosting integration
docs/fundamentals/integrations-overview.md .NET Aspire integrations overview
docs/toc.yml docs/toc

docs/community-toolkit/hosting-deno.md Outdated Show resolved Hide resolved
docs/community-toolkit/hosting-deno.md Outdated Show resolved Hide resolved
docs/community-toolkit/hosting-deno.md Outdated Show resolved Hide resolved
docs/community-toolkit/hosting-deno.md Outdated Show resolved Hide resolved
docs/community-toolkit/hosting-deno.md Outdated Show resolved Hide resolved
docs/community-toolkit/hosting-deno.md Outdated Show resolved Hide resolved
docs/community-toolkit/hosting-deno.md Outdated Show resolved Hide resolved
docs/community-toolkit/hosting-deno.md Outdated Show resolved Hide resolved
docs/community-toolkit/hosting-deno.md Outdated Show resolved Hide resolved
brian-guerrero and others added 9 commits October 26, 2024 10:38
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
@IEvangelist
Copy link
Member

IEvangelist commented Oct 27, 2024

Hi @brian-guerrero - This is a great start, thank you! The other thing that I noticed is that this is missing from the intergrations-overview.md page, there's a section that shows the Available integrations and part of that is a subsection with the Community toolkit integrations.

- Add Deno tasks and package installation support
```csharp
var builder = DistributedApplication.CreateBuilder(args);

builder.AddDenoApp("oak-demo", "main.ts", permissionFlags: ["-E", "--allow-net"])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know Deno very well, so maybe this is idiomatic as is, but as a newcomer I'd find --allow-env more helpful than -E.

They're equivalent according to the docs: https://docs.deno.com/runtime/fundamentals/security/#environment-variables

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of me showing both the long form and short form flags?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Community Toolkit] Deno
3 participants