Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add diag code for ConfigureCustomDomains. #1876

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Add diag code for ConfigureCustomDomains. #1876

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e03408
Add diag code for ConfigureCustomDomains.
mitchdenny Oct 21, 2024
e9f8af1
Blank lines lint error.
mitchdenny Oct 21, 2024
af9b338
Update overview.md
IEvangelist Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion docs/diagnostics/overview.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
title: .NET Aspire diagnostics overview
description: Learn about the diagnostics tools and features available in .NET Aspire.
ms.topic: overview
ms.date: 03/25/2024
ms.date: 10/21/2024
---

# .NET Aspire diagnostics overview
Expand All @@ -28,3 +28,23 @@ Alternatively, you can suppress this diagnostic with preprocessor directive by a
// API that is causing the warning.
#pragma warning restore AZPROVISION001
```

## ASPIREACADOMAINS001

.NET Aspire 9.0 introduces the ability to customize container app resources using the `PublishAsAzureContainerApp(...)` extension method. When using this method the Azure Developer CLI (`azd`) can no longer preserve custom domains. Instead use the `ConfigureCustomDomain` method to configure a custom domain within the .NET Aspire app host. The `ConfigureCustomDomain(...)` extension method is experimental. To suppress the compiler error/warning use the following code:

To suppress this diagnostic with the `SuppressMessageAttribute`, add the following code to your project:

```csharp
using System.Diagnostics.CodeAnalysis;

[assembly: SuppressMessage("ASPIREACADOMAINS001", "Justification")]
```

Alternatively, you can suppress this diagnostic with preprocessor directive by adding the following code to your project:

```csharp
#pragma warning disable ASPIREACADOMAINS001
// API that is causing the warning.
#pragma warning restore ASPIREACADOMAINS001
```
Loading