Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community Toolkit #1755

Merged
merged 31 commits into from
Oct 10, 2024
Merged

Community Toolkit #1755

merged 31 commits into from
Oct 10, 2024

Conversation

@dotnetrepoman dotnetrepoman bot added the fundamentals Content related to fundamentals. label Oct 3, 2024
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still a lot of things I'd like to clean up and fix

.github/CODEOWNERS Outdated Show resolved Hide resolved
docs/community-toolkit/hosting-azure-static-web-apps.md Outdated Show resolved Hide resolved
docs/community-toolkit/hosting-azure-static-web-apps.md Outdated Show resolved Hide resolved
docs/community-toolkit/hosting-azure-static-web-apps.md Outdated Show resolved Hide resolved
docs/community-toolkit/hosting-azure-static-web-apps.md Outdated Show resolved Hide resolved
docs/community-toolkit/hosting-nodejs-extensions.md Outdated Show resolved Hide resolved
@IEvangelist
Copy link
Member

Hey @aaronpowell - all of the build issues need to be addressed.

@IEvangelist
Copy link
Member

@aaronpowell - is the only thing the Community Toolkit is adding is "integrations"? If so, it's fine in the currently proposed TOC. Otherwise, if not, we'd likely want to move it to a top-level TOC.

@aaronpowell
Copy link
Contributor Author

@aaronpowell - is the only thing the Community Toolkit is adding is "integrations"? If so, it's fine in the currently proposed TOC. Otherwise, if not, we'd likely want to move it to a top-level TOC.

There's an overview page as well which helps outline the difference between the community toolkit and core repos.

All other docs are contributing docs which are in the repo as they wouldn't make sense on Learn.

@aaronpowell aaronpowell marked this pull request as ready for review October 9, 2024 22:56
@aaronpowell
Copy link
Contributor Author

Hey @aaronpowell - all of the build issues need to be addressed.

Build issues are fixed. Since we don't have the NuGet packages on nuget.org yet (still working through that process) I've changed them to be GitHub Packages links instead. Once we have NuGet available, then I'll update the links

@IEvangelist
Copy link
Member

@aaronpowell - I think we need a bit more variety in our alerts. We have five different types, but I must ask...are we really in need of so many alerts? They should only be used when absolutely needed.

image

@aaronpowell
Copy link
Contributor Author

@aaronpowell - I think we need a bit more variety in our alerts. We have five different types, but I must ask...are we really in need of so many alerts? They should only be used when absolutely needed.

haha yeah that does look a bit excessive doesn't it!

How much of these do you feel are required? I've gone with the "everything and the kitchen sink" approach, but really, other than the note at the very top, we can ditch the others as they are not super important.

.github/CODEOWNERS Outdated Show resolved Hide resolved
@IEvangelist IEvangelist enabled auto-merge (squash) October 10, 2024 13:02
@IEvangelist IEvangelist merged commit 5487af0 into dotnet:main Oct 10, 2024
7 checks passed
@aaronpowell aaronpowell deleted the community-toolkit branch October 10, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution fundamentals Content related to fundamentals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants