Skip to content

Conversation

@yufeih
Copy link
Contributor

@yufeih yufeih commented Nov 25, 2023

  • Extracts title from the first H1 for conceptual documents, which was previously from H1/H2/H3.
  • Drop IsUserDefinedTitle.
  • Consolidate conceptual build steps into one.

#3124

@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label Nov 25, 2023
@codecov
Copy link

codecov bot commented Nov 25, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0a3bd2c) 71.35% compared to head (fbf5e8e) 71.33%.

Files Patch % Lines
.../Docfx.Build/Conceptual/BuildConceptualDocument.cs 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9474      +/-   ##
==========================================
- Coverage   71.35%   71.33%   -0.02%     
==========================================
  Files         561      559       -2     
  Lines       24005    23994      -11     
  Branches     4177     4174       -3     
==========================================
- Hits        17128    17117      -11     
  Misses       5782     5782              
  Partials     1095     1095              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yufeih yufeih closed this Nov 25, 2023
@yufeih yufeih reopened this Nov 25, 2023
@yufeih yufeih merged commit 2c5d145 into main Nov 25, 2023
@yufeih yufeih deleted the h1 branch November 25, 2023 06:54
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants