Skip to content

fix: see/seealso tag copies href when a child node exist #8974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yufeih merged 1 commit into from
Jul 17, 2023
Merged

fix: see/seealso tag copies href when a child node exist #8974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Docfx.Dotnet/Resources/XmlCommentTransform.xsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<xsl:template match="see[@href and not(parent::member)]">
<a>
<xsl:apply-templates select="@*|node()"/>
<xsl:if test="not(text())">
<xsl:if test="not(node())">
<xsl:value-of select="@href"/>
</xsl:if>
</a>
Expand All @@ -37,7 +37,7 @@
<xsl:template match="seealso[@href and not(parent::member)]">
<a>
<xsl:apply-templates select="@*|node()"/>
<xsl:if test="not(text())">
<xsl:if test="not(node())">
<xsl:value-of select="@href"/>
</xsl:if>
</a>
Expand Down
7 changes: 7 additions & 0 deletions test/Docfx.Dotnet.Tests/XmlCommentUnitTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,13 @@ public static void Issue4165()
Assert.Equal("arg1", comment.Parameters["args"]);
}

[Fact]
public static void Issue8965()
{
Verify("<seealso href=\"https://github.com\"><em>See also on MDN</em></seealso>", "<a href=\"https://github.com\">\n <em>See also on MDN</em>\n</a>");
Verify("<see href=\"https://github.com\"><em>See also on MDN</em></see>", "<a href=\"https://github.com\">\n <em>See also on MDN</em>\n</a>");
}

[Fact]
public static void BasicCodeBlock()
{
Expand Down