Skip to content

Conversation

@filzrev
Copy link
Contributor

@filzrev filzrev commented Jul 15, 2023

What changed in this PR
Visual Studio Spell checker configs are added by this PR (#8940)
It works when these settings added. but after reloading projects. All settings are silently ignored.

It seems SpellCheker don't works as expected.
when spellcheck file contains non-ascii characters. (Need to separate dictionary?)

This PR temporary remove non-ascii chars from dictionary.
(These word is used by ExtractSearchIndexFromHtmlTest.cs)

@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8f411e0) 76.88% compared to head (785dc9a) 76.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8970   +/-   ##
=======================================
  Coverage   76.88%   76.89%           
=======================================
  Files         605      605           
  Lines       25074    25074           
=======================================
+ Hits        19279    19280    +1     
+ Misses       5795     5794    -1     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yufeih yufeih merged commit 93eb06f into dotnet:main Jul 16, 2023
@filzrev filzrev deleted the fix-spellcheck-error branch July 17, 2023 00:18
@yufeih yufeih added the engineering Makes the pull request to appear in the "Engineering" section of the next release note label Jul 24, 2023
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engineering Makes the pull request to appear in the "Engineering" section of the next release note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants