-
Notifications
You must be signed in to change notification settings - Fork 884
Add PDF generation ability to Microsoft.DocAsCode.App #8939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/Microsoft.DocAsCode.Build.Engine/TemplateProcessors/TemplateProcessor.cs
Outdated
Show resolved
Hide resolved
|
@dpvreony build failed with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tests that validate logs failed due to new warnings. We could either fix those tests or drop the new warning change.
|
@dpvreony It seems tests are still failing. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #8939 +/- ##
=======================================
Coverage 76.80% 76.80%
=======================================
Files 592 592
Lines 24716 24732 +16
=======================================
+ Hits 18983 18996 +13
- Misses 5733 5736 +3
☔ View full report in Codecov by Sentry. |
|
Thank you @dpvreony for adding this feature and taking the time to make sure tests work! |
Greetings
partial resolution of #8872