Skip to content

Conversation

@dpvreony
Copy link
Contributor

@dpvreony dpvreony commented Jul 5, 2023

Greetings

  • Adds the ability to target the pdf config section in docfx.json
  • Adds logging around templates not being resolved, as came across an issue which had no logging and results in 'No TOC file is included, no PDF file will be generated'

partial resolution of #8872

@yufeih
Copy link
Contributor

yufeih commented Jul 6, 2023

@dpvreony build failed with:


Error: /home/runner/work/docfx/docfx/test/docfx.Tests/DocsetTest.cs(198,30): error xUnit1013: Public method 'Build_With_RedirectUri_Files' on test class 'DocsetTest' should be marked as a Fact. Reduce the visibility of the method, or add a Fact attribute to the method. [/home/runner/work/docfx/docfx/test/docfx.Tests/docfx.Tests.csproj::TargetFramework=net6.0]
Error: /home/runner/work/docfx/docfx/test/docfx.Tests/DocsetTest.cs(198,30): error xUnit1013: Public method 'Build_With_RedirectUri_Files' on test class 'DocsetTest' should be marked as a Fact. Reduce the visibility of the method, or add a Fact attribute to the method. [/home/runner/work/docfx/docfx/test/docfx.Tests/docfx.Tests.csproj::TargetFramework=net8.0]
Error: /home/runner/work/docfx/docfx/test/docfx.Tests/DocsetTest.cs(198,30): error xUnit1013: Public method 'Build_With_RedirectUri_Files' on test class 'DocsetTest' should be marked as a Fact. Reduce the visibility of the method, or add a Fact attribute to the method. [/home/runner/work/docfx/docfx/test/docfx.Tests/docfx.Tests.csproj::TargetFramework=net7.0]

Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests that validate logs failed due to new warnings. We could either fix those tests or drop the new warning change.

@yufeih
Copy link
Contributor

yufeih commented Jul 12, 2023

@dpvreony It seems tests are still failing.

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 61.11% and no project coverage change.

Comparison is base (1aa67a6) 76.80% compared to head (a33973d) 76.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8939   +/-   ##
=======================================
  Coverage   76.80%   76.80%           
=======================================
  Files         592      592           
  Lines       24716    24732   +16     
=======================================
+ Hits        18983    18996   +13     
- Misses       5733     5736    +3     
Impacted Files Coverage Δ
src/Docfx.App/Docset.cs 73.07% <53.33%> (-26.93%) ⬇️
...ine/TemplateProcessors/TemplateModelTransformer.cs 85.18% <100.00%> (+0.07%) ⬆️
...ild.Engine/TemplateProcessors/TemplateProcessor.cs 88.23% <100.00%> (+0.35%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yufeih
Copy link
Contributor

yufeih commented Jul 18, 2023

Thank you @dpvreony for adding this feature and taking the time to make sure tests work!

@yufeih yufeih enabled auto-merge (squash) July 18, 2023 00:38
@yufeih yufeih disabled auto-merge July 18, 2023 00:38
@yufeih yufeih merged commit 291863d into dotnet:main Jul 18, 2023
@yufeih yufeih added the new-feature Makes the pull request to appear in "New Features" section of the next release note label Jul 24, 2023
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature Makes the pull request to appear in "New Features" section of the next release note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants