-
Notifications
You must be signed in to change notification settings - Fork 884
deps: Update @typescript-eslint package
#10866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
3a5218a to
d463be9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the @typescript-eslint packages from version 8.44.1 to 8.46.2 and fixes the "Cannot redefine plugin '@typescript-eslint'" error by reusing the TypeScript ESLint plugin exported by the neostandard package instead of importing it directly.
Key Changes
- Updated
@typescript-eslint/eslint-pluginand@typescript-eslint/parserto version 8.46.2 - Modified ESLint configuration to reference the TypeScript ESLint plugin from neostandard's exported plugins
- Removed direct import of
@typescript-eslint/eslint-pluginfrom eslint.config.js
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| templates/package.json | Updated versions of @typescript-eslint packages from 8.44.1 to 8.46.2 |
| templates/package-lock.json | Updated dependency tree reflecting version 8.46.2 for all @typescript-eslint packages and their transitive dependencies |
| templates/eslint.config.js | Removed direct import of @typescript-eslint/eslint-plugin and now references the plugin from neostandard.plugins to avoid plugin redefinition |
Files not reviewed (1)
- templates/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import {defineConfig, globalIgnores} from 'eslint/config' | ||
| import js from '@eslint/js' | ||
| import tsesLint from 'typescript-eslint' | ||
| import tsesLintParser from '@typescript-eslint/parser' |
Copilot
AI
Dec 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parser is still being imported directly from @typescript-eslint/parser, but the plugin is now sourced from neostandard. For consistency and to avoid potential version mismatches or plugin conflicts, consider also using the parser from neostandard if it's exported, similar to how the plugin is now being accessed via neostandard.plugins['typescript-eslint'].plugin.
d463be9 to
a3e0016
Compare
|
I've updated dependencies. @yufeih |
This PR intended to superseded PR #10829.
When
@typescript-eslintpackages are updated to latest version.It cause
Cannot redefine plugin "@typescript-eslint"error.This PR contains following changes.
#10829).eslint.config.jsfile to reuse plugin that is exported byneostandardpackage.