Skip to content

chore: Update docker file#10093

Merged
yufeih merged 1 commit intodotnet:mainfrom
filzrev:chore-updates-dockerfile
Jul 9, 2024
Merged

chore: Update docker file#10093
yufeih merged 1 commit intodotnet:mainfrom
filzrev:chore-updates-dockerfile

Conversation

@filzrev
Copy link
Collaborator

@filzrev filzrev commented Jul 9, 2024

This PR include following changes.

  1. Specify install docfx version explicitly
    Without this setting. Docker try to use cached layer if exists. In this case it need to manually clear cache.
  2. Remove unused files to reduce docker image size
    2.1. .nupkg files
    2.2. Executables for .NET 6
  3. Additional Node.js installation (Required for feat: Remove Node.js runtime dependencies from docfx tools #10066)
  4. Pre-Install Chromium browser

Note: By #10066) changes. directory structures are not matched to playwright.ps1 expecting structure.
So It need to create temporary symlink to run playwright.ps1.

Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@yufeih yufeih added the new-feature Makes the pull request to appear in "New Features" section of the next release note label Jul 9, 2024
@yufeih yufeih merged commit f0703bf into dotnet:main Jul 9, 2024
@yufeih yufeih added performance Makes the pull request appear in "Performance" section of the next release note and removed new-feature Makes the pull request to appear in "New Features" section of the next release note labels Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Makes the pull request appear in "Performance" section of the next release note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants