-
Notifications
You must be signed in to change notification settings - Fork 382
Sync eng/native with runtime #5612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Added cache value for HAVE_PROCFS_MAPS_EXITCODE.
|
@hoyosjs, @mikem8361, can you please run other / official legs against the PR so we can validate there is no regression? The only diff with dontet/runtime's eng/native (including dotnet/runtime#121071) is additional |
| </Choose> | ||
|
|
||
| <Choose> | ||
| <When Condition="$(TargetRid.StartsWith('win'))"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably breaks dbgshim packaging. I can run the official leg but see
diagnostics/src/dbgshim/pkg/Microsoft.Diagnostics.DbgShim.props
Lines 17 to 21 in d4961a0
| <ItemGroup> | |
| <None Include="$(NativeBinDir)$(LibPrefix)dbgshim$(LibSuffix)" | |
| PackagePath="runtimes/$(PackageRID)/native" | |
| Pack="true" /> | |
| </ItemGroup> |
We don't use targetRid since that's not correct on our packaging leg - we use a vertical for these packages since a fair number of our packages have RID assets from all different verticals.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good catch. In runtime, arcade, VMR etc. PackageRID/OutputRID were removed, we are using TargetRid. I've renamed them.
|
@am11 - do you see any use of HAVE_PROCFS_MAPS_EXITCODE? I couldn't see any referencing code. |
|
|
|
TargetRid sadly has different semantic meaning here. We pass it down. Line 197 in 73f1fdc
|
|
@hoyosjs do you have a repro? I’m not sure what the intended forward path is; the goal of eng/native was to stay aligned with runtime, so new configs wouldn’t require duplicate engineering work. |
No description provided.