Skip to content

[SOS][tests] Fix OtherCommands test failure on Alpine Linux #5489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 21, 2025
Merged

[SOS][tests] Fix OtherCommands test failure on Alpine Linux #5489

merged 4 commits into from
May 21, 2025

Conversation

Copy link
Contributor

Copilot AI commented May 20, 2025 •
edited by noahfalk
Loading

Problem

In the past SOS.OtherCommands test was failing on Alpine Linux with error:

System.Exception : VerifyOutput: no last command output or debugger exited unexpectedly: \s*Name:\s+SymbolTestApp.Program\s+

We believe the issue was resolved in #5421 but the tests had never been re-enabled. This PR re-enables the test.

Fixes #4654.

Copilot AI changed the title [WIP] [SOS][tests] OtherCommands(config: projectk.sdk.prebuilt*) VerifyOutput: no last command output or debugger exited unexpectedly [SOS][tests] Fix OtherCommands test failure on Alpine Linux May 20, 2025
Copilot AI requested a review from noahfalk May 20, 2025 21:27
Copilot finished work on behalf of noahfalk May 20, 2025 21:27
noahfalk
noahfalk previously requested changes May 20, 2025
View reviewed changes
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please discard your current changes and instead revert the changes that were made in PR #4656.

Copy link
Contributor Author

Copilot AI commented May 20, 2025

Please discard your current changes and instead revert the changes that were made in PR #4656.

I've reverted the changes from PR #4656 as requested. The OtherCommands.script file has been restored to its original state, without the Alpine-specific conditional logic for the DumpMT command (bbd7a30).

Copilot finished work on behalf of noahfalk May 20, 2025 21:40
@noahfalk noahfalk marked this pull request as ready for review May 21, 2025 00:03
@noahfalk noahfalk requested a review from a team as a code owner May 21, 2025 00:03
hoyosjs
hoyosjs approved these changes May 21, 2025
View reviewed changes
Copy link
Member

@hoyosjs hoyosjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided the test passes.

@noahfalk
Copy link
Member

noahfalk commented May 21, 2025

Provided the test passes.

The PR reports all the tests are passing so unless there is some other verification needed I think we're good now.

@noahfalk noahfalk self-requested a review May 21, 2025 00:12
noahfalk
noahfalk reviewed May 21, 2025
View reviewed changes
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I can't approve because I was the copilot initiator)

@noahfalk noahfalk dismissed their stale review May 21, 2025 00:14

My comments were addressed

@noahfalk noahfalk enabled auto-merge (squash) May 21, 2025 00:14
@lateralusX lateralusX self-requested a review May 21, 2025 07:11
@noahfalk noahfalk merged commit 2650c60 into main May 21, 2025
21 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@noahfalk noahfalk noahfalk left review comments

@lateralusX lateralusX lateralusX approved these changes

@hoyosjs hoyosjs hoyosjs approved these changes

Assignees

@noahfalk noahfalk

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[SOS][tests] OtherCommands(config: projectk.sdk.prebuilt*) VerifyOutput: no last command output or debugger exited unexpectedly

4 participants

@noahfalk @lateralusX @hoyosjs