Skip to content

Fix parsing of thread names #3860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 2, 2023
Merged

Fix parsing of thread names #3860

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e65fc36
Fix parsing of thread names
grisha-kotler Apr 28, 2023
278536f
Use explicit type instead of 'var'
grisha-kotler Apr 30, 2023
78950dc
use char overload
grisha-kotler May 1, 2023
0eb5b90
use Span instead of Substring
grisha-kotler May 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Tools/dotnet-stack/ReportCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,11 @@ private static async Task<int> Report(CancellationToken ct, IConsole console, in
// Thread id is in the frame name as "Thread (<ID>)"
string template = "Thread (";
string threadFrame = stackSource.GetFrameName(stackSource.GetFrameIndex(stackIndex), false);
int threadId = int.Parse(threadFrame.Substring(template.Length, threadFrame.Length - (template.Length + 1)));

// we are looking for the first index of ) because
// we need to handle a thread name like: Thread (4008) (.NET IO ThreadPool Worker)
int firstIndex = threadFrame.IndexOf(")");
Copy link
Member

@gfoidl gfoidl May 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
int firstIndex = threadFrame.IndexOf(")");
int firstIndex = threadFrame.IndexOf(')');

The char-overload is cheaper than the string-ovrelaod.

Copy link
Contributor Author

@grisha-kotler grisha-kotler May 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

int threadId = int.Parse(threadFrame.Substring(template.Length, firstIndex - template.Length));
Copy link
Member

@gfoidl gfoidl May 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of Substring the span-overload for int.Parse could be used.

Copy link
Contributor Author

@grisha-kotler grisha-kotler May 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


if (samplesForThread.TryGetValue(threadId, out List<StackSourceSample> samples))
{
Expand Down