Fix some workflow issues

[am11]

1. idempotently generate version file.
2. allow double hyphen in args.

[am11]

@jkoritzinsky, in official build, we always build from clean repo so I assumed this won't be a problem.

[jkoritzinsky]

Yes we always build from a clean clone for an official build.

[mikem8361]

Is this PR ready to go? It looks fine to me.

[am11]

This and dotnet/runtime#61027 are mirror PRs. Ready for review. @hoyosjs, could you please take a look?

As a next step, we can look into moving bits from eng/native to eng/common/native to nail out code duplication across repos, which make use of native infra.

[hoyosjs]

Sorry, thought I'd commented here that I was going to complete the fix last week. Time just didn't allow. The PR does solve an issue of the incrementality somewhat, I'm fine with it going as is. However, it doesn't solve some of the issues that were introduced in our infra. The runtime uses versioning.targets and it's connected in no way in this repo. This means SOS ends up with versioning info like this in our official builds:

@(#)Version N/A @Commit: a3464a7

I'll likely just add a call in build.ps1/sh to an msbuild phony target to generate the files.

[am11]

The runtime uses versioning.targets and it's connected in no way in this repo. This means SOS ends up with versioning info like this in our official builds:

I remember testing it with ./build.sh -p:OfficialBuildId=$(date +%Y%m%d)-99, and while PR was being reviewed, dotnet/runtime@4682098 was merged and I resync with upstream. I will check it out. However, infra is not too different. Both runtime and diagnostics eventually rely on what comes from arcade's versioning target (with some post-processing and fallback).

[hoyosjs]

The runtime uses versioning.targets and it's connected in no way in this repo. This means SOS ends up with versioning info like this in our official builds:

I remember testing it with ./build.sh -p:OfficialBuildId=$(date +%Y%m%d)-99, and while PR was being reviewed, dotnet/runtime@4682098 was merged and I resync with upstream. I will check it out. However, infra is not too different. Both runtime and diagnostics eventually rely on what comes from arcade's versioning target (with some post-processing and fallback).

@am11 yup, and it's not a big deal. I was just going to bolt on the fix. I just ended up doing a fairly rabbit-hole investigation and ended up not doing it last week. That commit that you pointed out handles it in runtime.proj. We don't have an equivalent entrypoint to native on this project and we don't have the subsets, hence I said most likely just a call into empty.proj with an explicit target call. I'll probably do it with another versioning change I have to do.