Add open question about partial constructors in top-level statements #9085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cston
approved these changes
Jan 23, 2025
| ``` | ||
|
|
||
| Do we want to keep this behavior or can we break here and simplify the parser? | ||
| If we break, the workaround for users is to use `@partial` for the return type of the method as well. |
Member
There was a problem hiding this comment.
Note: searching github, i don't see any hits for partial identifier(. So it seems unlikely that peopel are doing this. Similar to how we've carved out other identifiers and stated we will only interpret them as a modifier and not a type (record, scoped, etc.) this feels very much in line with going the same route.
Esp. given no matches in the wild, this seems safe and sane.
Member
There was a problem hiding this comment.
Also, there is a little while until next LDM, perhaps we should float this question by email.
Member
There was a problem hiding this comment.
i would be fine with email :) @jjonescz do you want to send?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.