This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Wasm: add support for ovf op with char type #8257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
reviewed
Aug 10, 2020
| case ILOpcode.add_ovf: | ||
| Debug.Assert(type.Category == TypeFlags.Int32 || type.Category == TypeFlags.Int64); | ||
| if (type.Category == TypeFlags.Int32) | ||
| Debug.Assert(type.Category == TypeFlags.Int32 || type.Category == TypeFlags.Int64 || type.Category == TypeFlags.Char); |
Member
There was a problem hiding this comment.
It does not sound right to have char on the IL stack. Should char be converted to int32 when it gets loaded onto the IL stack instead?
Member
There was a problem hiding this comment.
ILVerify does it in StackValue.CreateFromType method.
Contributor
Author
There was a problem hiding this comment.
Webassembly stack entries keep both the StackValueKind and the TypeDesc . I've changed these asserts and ifs to use thte StackValueKind which I think is more correct and inline with StackValue.CreateFromType
jkotas
approved these changes
Aug 10, 2020
Member
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a compiler assert when compiling https://github.com/dotnet/corert/blob/master/src/System.Private.CoreLib/shared/System/Environment.Unix.cs#L111 as the char type was not included in the int32 path. Types short and byte seem ok before this change so no code added for those.