This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Wasm: split llvm->wasm from wasm link #8253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates the compilation from LLVM bitcode to final
.wasm. There are now 2 steps in the buildThe advantages are:
wasm-ldand can't be turned off. Now it can be turned off resulting in faster linking..o. Threads are not enabled yet but this is a step towards that. Cannot compile pthreads application with WASM backend: Target feature 'atomics' is disallowed emscripten-core/emscripten#10370Another possible advantage is if the LLVM bitcode was to be used to build another target, then maybe this separation will help.