This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Preinit, fix ldlen to push 32 bit value when pointer size is 4 #8209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
CI has failed with the intermittent Wasm out of memory error again. Seems to be getting less intermittent which is good from a finding it point of view. https://dev.azure.com/dnceng/public/_build/results?buildId=692298&view=logs&j=c5ae3b21-06ed-5684-ebd6-da75bd1a710c&t=dd4a14a5-1805-5b09-b2dd-9305bee1bcc9&l=1508 If our luck is in then, #8171 will fix this, but I don't know for sure that any garbage collection has occurred. I'll continue to try to get a local failure, for this PR, can either wait, or resubmit. |
Member
The generics test does quite a bit of work so I wouldn't be surprised if we see multiple GCs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8208
This PR changes the pushed value type from Int64 to Int32 for 32bit architectures.