This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
BufferWriter.WriteLine String/Utf8String #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YohDeadfall
reviewed
Mar 22, 2018
| @@ -19,6 +19,8 @@ public BufferWriter(T output) | |||
| _span = output.GetSpan(); | |||
| } | |||
|
|
|||
| public ReadOnlySpan<byte> NewLine; | |||
There was a problem hiding this comment.
yeah, I copied/pasted it from the non-generic writer. It should be a property. I will change.
| public void Write(int value, StandardFormat format = default) | ||
| { | ||
| int written; | ||
| while (!Utf8Formatter.TryFormat(value, Buffer, out written, format)) |
There was a problem hiding this comment.
Just for myself. Why don't you use out variables? Is it because of the coding style?
There was a problem hiding this comment.
You mean why don't I do "out int written"? If yes, then because of scoping. I need written outside of the while loop.
There was a problem hiding this comment.
Ah, thanks. Didn't know the expression variable scoping is different for loops.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added WriteLine to BufferWriter
Refactored and renamed some files.