Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Added System.Buffers.ReaderWriter #2155

Merged
merged 2 commits into from
Mar 12, 2018
Merged

Added System.Buffers.ReaderWriter #2155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
737807a
Refactored Reader/Writer
KrzysztofCwalina Mar 12, 2018
3131142
More refactoring
KrzysztofCwalina Mar 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions corefxlab.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,8 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "System.Azure.Experimental",
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "System.IO.Pipelines.Extensions.Tests", "tests\System.IO.Pipelines.Extensions.Tests\System.IO.Pipelines.Extensions.Tests.csproj", "{64C08774-982C-4141-8F8D-2884B6FA0E4B}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "System.Buffers.ReaderWriter", "src\System.Buffers.ReaderWriter\System.Buffers.ReaderWriter.csproj", "{C5F9D191-CA3B-4648-B8A9-62E33B4622EB}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand Down Expand Up @@ -892,6 +894,18 @@ Global
{64C08774-982C-4141-8F8D-2884B6FA0E4B}.Release|x64.Build.0 = Release|Any CPU
{64C08774-982C-4141-8F8D-2884B6FA0E4B}.Release|x86.ActiveCfg = Release|Any CPU
{64C08774-982C-4141-8F8D-2884B6FA0E4B}.Release|x86.Build.0 = Release|Any CPU
{C5F9D191-CA3B-4648-B8A9-62E33B4622EB}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{C5F9D191-CA3B-4648-B8A9-62E33B4622EB}.Debug|Any CPU.Build.0 = Debug|Any CPU
{C5F9D191-CA3B-4648-B8A9-62E33B4622EB}.Debug|x64.ActiveCfg = Debug|Any CPU
{C5F9D191-CA3B-4648-B8A9-62E33B4622EB}.Debug|x64.Build.0 = Debug|Any CPU
{C5F9D191-CA3B-4648-B8A9-62E33B4622EB}.Debug|x86.ActiveCfg = Debug|Any CPU
{C5F9D191-CA3B-4648-B8A9-62E33B4622EB}.Debug|x86.Build.0 = Debug|Any CPU
{C5F9D191-CA3B-4648-B8A9-62E33B4622EB}.Release|Any CPU.ActiveCfg = Release|Any CPU
{C5F9D191-CA3B-4648-B8A9-62E33B4622EB}.Release|Any CPU.Build.0 = Release|Any CPU
{C5F9D191-CA3B-4648-B8A9-62E33B4622EB}.Release|x64.ActiveCfg = Release|Any CPU
{C5F9D191-CA3B-4648-B8A9-62E33B4622EB}.Release|x64.Build.0 = Release|Any CPU
{C5F9D191-CA3B-4648-B8A9-62E33B4622EB}.Release|x86.ActiveCfg = Release|Any CPU
{C5F9D191-CA3B-4648-B8A9-62E33B4622EB}.Release|x86.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand Down Expand Up @@ -959,6 +973,7 @@ Global
{0BA3C0A9-64B9-445D-B085-8FFAC09D6E37} = {3079E458-D0E6-4F99-8CAB-80011D35C7DA}
{916370AB-B0D3-4136-850B-AA12FAB23ECD} = {4B000021-5278-4F2A-B734-DE49F55D4024}
{64C08774-982C-4141-8F8D-2884B6FA0E4B} = {3079E458-D0E6-4F99-8CAB-80011D35C7DA}
{C5F9D191-CA3B-4648-B8A9-62E33B4622EB} = {4B000021-5278-4F2A-B734-DE49F55D4024}
EndGlobalSection
GlobalSection(ExtensibilityGlobals) = postSolution
SolutionGuid = {9DD4022C-A010-4A9B-BCC5-171566D4CB17}
Expand Down
1 change: 1 addition & 0 deletions src/System.Azure.Experimental/System.Azure.Experimental.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
<ItemGroup>
<ProjectReference Include="..\System.Binary.Base64\System.Binary.Base64.csproj" />
<ProjectReference Include="..\System.Buffers.Experimental\System.Buffers.Experimental.csproj" />
<ProjectReference Include="..\System.Buffers.ReaderWriter\System.Buffers.ReaderWriter.csproj" />
<ProjectReference Include="..\System.Text.Encodings.Web.Utf8\System.Text.Encodings.Web.Utf8.csproj" />
</ItemGroup>
</Project>
0 ...ary.Base64/System/Binary/Base64Decoder.cs → src/System.Binary.Base64/Base64Decoder.cs
View file
Open in desktop
File renamed without changes.
0 ...ary.Base64/System/Binary/Base64Encoder.cs → src/System.Binary.Base64/Base64Encoder.cs
View file
Open in desktop
File renamed without changes.
0 ...s.Primitives/System/Buffers/OwnedArray.cs → ...Experimental/System/Buffers/OwnedArray.cs
View file
Open in desktop
File renamed without changes.
4 changes: 0 additions & 4 deletions ...imitives/System/Buffers/Transformation.cs → ...itives/System/Buffers/IBufferOperation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,4 @@ public interface IBufferOperation
{
OperationStatus Execute(ReadOnlySpan<byte> input, Span<byte> output, out int consumed, out int written);
}
public interface IBufferTransformation : IBufferOperation
{
OperationStatus Transform(Span<byte> buffer, int dataLength, out int written);
}
}
11 changes: 11 additions & 0 deletions src/System.Buffers.Primitives/System/Buffers/IBufferTransformation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

namespace System.Buffers
{
public interface IBufferTransformation : IBufferOperation
{
OperationStatus Transform(Span<byte> buffer, int dataLength, out int written);
}
}
111 changes: 0 additions & 111 deletions src/System.Buffers.Primitives/System/Buffers/ThrowHelper.cs
View file
Open in desktop

This file was deleted.

17 changes: 17 additions & 0 deletions src/System.Buffers.ReaderWriter/System.Buffers.ReaderWriter.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<Project Sdk="Microsoft.NET.Sdk">
<Import Project="..\..\tools\common.props" />
<PropertyGroup>
<Description>Buffer Readers, Writers, and Transformations</Description>
<TargetFramework>netstandard1.3</TargetFramework>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<PackageTags>Span BufferReader BufferWriter corefxlab</PackageTags>
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\System.Collections.Sequences\System.Collections.Sequences.csproj" />
<ProjectReference Include="..\System.Text.Primitives\System.Text.Primitives.csproj" />
<ProjectReference Include="..\System.Text.Utf8String\System.Text.Utf8String.csproj" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="System.IO.Pipelines" Version="$(SystemIOPipelinesVersion)" />
</ItemGroup>
</Project>
0 ...erimental/System/Buffers/IPipeWritable.cs → ...derWriter/System/Buffers/IPipeWritable.cs
View file
Open in desktop
File renamed without changes.
0 ...tal/System/Buffers/BufferReader_binary.cs → ...tem/Buffers/Reader/BufferReader_binary.cs
View file
Open in desktop
File renamed without changes.
0 ...tal/System/Buffers/BufferReader_search.cs → ...tem/Buffers/Reader/BufferReader_search.cs
View file
Open in desktop
File renamed without changes.
0 ...ental/System/Buffers/BufferReader_text.cs → ...ystem/Buffers/Reader/BufferReader_text.cs
View file
Open in desktop
File renamed without changes.
0 ...es/System/Buffers/ReadOnlyBufferReader.cs → ...em/Buffers/Reader/ReadOnlyBufferReader.cs
View file
Open in desktop
File renamed without changes.
0 ...ffers.Experimental/RemoveTranstomation.cs → ...rs/Transformations/RemoveTranstomation.cs
View file
Open in desktop
File renamed without changes.
0 ...ental/System/Buffers/Text/BufferWriter.cs → ...ter/System/Buffers/Writer/BufferWriter.cs
View file
Open in desktop
File renamed without changes.
0 ...tem/Buffers/Text/BufferWriter_datetime.cs → ...m/Buffers/Writer/BufferWriter_datetime.cs
View file
Open in desktop
File renamed without changes.
0 .../System/Buffers/Text/BufferWriter_ints.cs → ...ystem/Buffers/Writer/BufferWriter_ints.cs
View file
Open in desktop
File renamed without changes.
0 ...tem/Buffers/Text/BufferWriter_sequence.cs → ...m/Buffers/Writer/BufferWriter_sequence.cs
View file
Open in desktop
File renamed without changes.
0 ...stem/Buffers/Text/BufferWriter_strings.cs → ...em/Buffers/Writer/BufferWriter_strings.cs
View file
Open in desktop
File renamed without changes.
0 ...tem/Buffers/Text/BufferWriter_writable.cs → ...m/Buffers/Writer/BufferWriter_writable.cs
View file
Open in desktop
File renamed without changes.
0 ...itives/System/Buffers/OutputExtensions.cs → ...System/Buffers/Writer/OutputExtensions.cs
View file
Open in desktop
File renamed without changes.
0 ...Primitives/System/Buffers/OutputWriter.cs → ...ter/System/Buffers/Writer/OutputWriter.cs
View file
Open in desktop
File renamed without changes.
0 ...stem/Buffers/Text/TransformationFormat.cs → ...em/Buffers/Writer/TransformationFormat.cs
View file
Open in desktop
File renamed without changes.
37 changes: 37 additions & 0 deletions src/System.Buffers.ReaderWriter/System/ThrowHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
// Copyright (c) Microsoft. All rights reserved.
// Licensed under the MIT license. See LICENSE file in the project root for full license information.

using System.Diagnostics;
using System.Runtime.CompilerServices;

namespace System.Buffers
{
internal class ThrowHelper
{
public static void ThrowArgumentOutOfRangeException(ExceptionArgument argument)
{
throw GetArgumentOutOfRangeException(argument);
}

[MethodImpl(MethodImplOptions.NoInlining)]
private static ArgumentOutOfRangeException GetArgumentOutOfRangeException(ExceptionArgument argument)
{
return new ArgumentOutOfRangeException(GetArgumentName(argument));
}

private static string GetArgumentName(ExceptionArgument argument)
{
Debug.Assert(Enum.IsDefined(typeof(ExceptionArgument), argument),
"The enum value is not defined, please check the ExceptionArgument Enum.");

return argument.ToString();
}
}

internal enum ExceptionArgument
{

length,

}
}
1 change: 1 addition & 0 deletions src/System.Text.Http.Parser/System.Text.Http.Parser.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\System.Buffers.Experimental\System.Buffers.Experimental.csproj" />
<ProjectReference Include="..\System.Buffers.ReaderWriter\System.Buffers.ReaderWriter.csproj" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="System.IO.Pipelines" Version="$(SystemIOPipelinesVersion)" />
Expand Down
1 change: 1 addition & 0 deletions src/System.Text.Http/System.Text.Http.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
<LangVersion>7.2</LangVersion>
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="..\System.Buffers.ReaderWriter\System.Buffers.ReaderWriter.csproj" />
<ProjectReference Include="..\System.Text.Formatting\System.Text.Formatting.csproj" />
<ProjectReference Include="..\System.Text.Http.Parser\System.Text.Http.Parser.csproj" />
</ItemGroup>
Expand Down
0 ...s/System/Buffers/SpanLiteralExtensions.cs → ...Primitives.Tests/SpanLiteralExtensions.cs
View file
Open in desktop
File renamed without changes.
2 changes: 2 additions & 0 deletions tests/System.Buffers.Primitives.Tests/System.Buffers.Primitives.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@
</ItemGroup>
<!-- Project references -->
<ItemGroup>
<ProjectReference Include="..\..\src\System.Buffers.Experimental\System.Buffers.Experimental.csproj" />
<ProjectReference Include="..\..\src\System.Buffers.Primitives\System.Buffers.Primitives.csproj" />
<ProjectReference Include="..\..\src\System.Buffers.ReaderWriter\System.Buffers.ReaderWriter.csproj" />
</ItemGroup>
<!-- register for test discovery in Visual Studio -->
<ItemGroup>
Expand Down