Updated AzCopyCore sample to new corfxlab APIs #2122
Conversation
| <PackageReference Include="System.Text.Http" Version="0.1.0-preview2-180209-2" /> | ||
| <PackageReference Include="System.Text.Http.Parser" Version="0.1.0-preview2-180209-2" /> | ||
| <PackageReference Include="System.Threading.Tasks.Extensions" Version="4.5.0-preview2-26209-05" /> | ||
| <PackageReference Include="System.Azure.Experimental" Version="0.1.0-preview2-180213-4" /> |
There was a problem hiding this comment.
Consider adding it to the solution and reference the libraries directly (we have some samples which are written this way already). This would remove the need to keep updating these versions.
Also consider importing common.props and remove the RuntimeFrameworkVersion attribute.
See the following as an example:
https://github.com/dotnet/corefxlab/blob/master/samples/QotdService/QotdService.csproj
There was a problem hiding this comment.
I kind like the samples being standalone apps as opposed to having to build them with the whole repo.
There was a problem hiding this comment.
I am fine with that. Should we add this standalone sample to the build script though so it gets built as part of the CI run? It would require no additional changes if it was part of the solution file. Otherwise, we can just add a "build samples" step.
There was a problem hiding this comment.
Yeah, I will do it tomorrow.
No description provided.