This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
Removed Position.End #1988
Merged
Removed Position.End #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @pakrym, @davidfowl, @joshfree, @ahsonkhan
When sequences move to end default(Position) is returned from TryGet
Before calling ISequence.TryGet for the first time, the calling code has to call ISequence.First, as default position no longer mean the first item (necessarily)
APIs like buffer.PositionOf(byte value) return Position? (nullable). They return null if value is not found
All these changes were requested by @pakrym to allow him to use Position in pipelines instead of ReadCursor.