This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
Changed IMemoryList based on Pipelines API Review #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Getting closer |
pakrym
approved these changes
Dec 15, 2017
davidfowl
suggested changes
Dec 15, 2017
| @@ -9,6 +9,118 @@ | |||
|
|
|||
| namespace System.Buffers | |||
| { | |||
|
|
|||
| public static class MemoryListExtensions | |||
There was a problem hiding this comment.
Are we going to use the ReadableBuffer implementation?
There was a problem hiding this comment.
For?
BTW, this project is not even referenced by the pipelines. I needed to add all these extension methods below to be able to compile existing code (in this project) after removing CopyTo, and ISequence implementations from IMemoryList. i.e. there is no plan to ship these members.
davidfowl
approved these changes
Dec 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pakrym, @ahsonkhan, @joshfree