Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Port Utf8Utility Performance test to BenchmarkDotNet #2319

Closed
ahsonkhan opened this issue May 31, 2018 · 1 comment
Closed

Port Utf8Utility Performance test to BenchmarkDotNet #2319

ahsonkhan opened this issue May 31, 2018 · 1 comment
Assignees
@kant2002
Labels
area-System.Text.Primitives Hackathon Issues picked for Hackathon on 2018/6/2 test-enhancement up-for-grabs
Milestone
3.0

Comments

@ahsonkhan
Copy link
Member

ahsonkhan commented May 31, 2018 •
edited
Loading

We have some Utf8Utility performance tests that need to be ported from xunit.performance to BenchmarkDotNet.

corefxlab/tests/System.Text.Primitives.Tests/Encoding/Performance/Utf8UtilityPerfTests.cs

Line 11 in 89ea88c

public class Utf8UtilityPerfTests

Follow the examples from previous efforts to port the performance tests:
#2240
#2241
#2242
#2243
#2249
#2254
#2260

cc @adamsitnik, @GrabYourPitchforks
@ahsonkhan ahsonkhan added this to the 2.2.0 milestone May 31, 2018
@ahsonkhan ahsonkhan mentioned this issue May 31, 2018
Closed
@kant2002
Copy link
Collaborator

kant2002 commented Jun 3, 2018

I will take a look at this.

@kant2002 kant2002 mentioned this issue Jun 3, 2018
Merged
adamsitnik pushed a commit that referenced this issue Jun 3, 2018
@kant2002 @adamsitnik
Migrate UTF8 decoding benchmarks to Benchmark.DotNet (#2334), fixes #…
67620c5 
…2319

* Migrate UTF8 decoding benchmarks to Benchmark.DotNet

* Code cleanup
- Remove not used variable
- Simplify setup code using expression methods
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kant2002 kant2002

Labels
area-System.Text.Primitives Hackathon Issues picked for Hackathon on 2018/6/2 test-enhancement up-for-grabs
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
2 participants
@kant2002 @ahsonkhan