Remove use of DangerousGetPinnableReference and use Memory.GetReferen…

…ce instead (#1985)

* Remove use of DangerousGetPinnableReference and use Memory.GetReference instead

* Misses some references to DangerousGetPinnableReference in sample projects

samples/LowAllocationWebServer/LowAllocationWebServerLibrary/TcpServer.cs

@@ -4,6 +4,7 @@
 
 using Microsoft.Net.Interop;
 using System;
+using System.Runtime.InteropServices;
 
 namespace Microsoft.Net.Sockets
 {
@@ -163,7 +164,7 @@ public void Close()
         public unsafe int Send(ReadOnlySpan<byte> buffer)
         {
             // TODO: This can work with Span<byte> because it's synchronous but we need async pinning support
-            fixed (byte* bytes = &buffer.DangerousGetPinnableReference())
+            fixed (byte* bytes = &MemoryMarshal.GetReference(buffer))
             {
                 IntPtr pointer = new IntPtr(bytes);
                 return SendPinned(pointer, buffer.Length);
@@ -193,7 +194,7 @@ public int Send(byte[] bytes, int offset, int count)
         public unsafe int Receive(Span<byte> buffer)
         {
             // TODO: This can work with Span<byte> because it's synchronous but we need async pinning support
-            fixed (byte* bytes = &buffer.DangerousGetPinnableReference())
+            fixed (byte* bytes = &MemoryMarshal.GetReference(buffer))
             {
                 IntPtr pointer = new IntPtr(bytes);
                 return ReceivePinned(pointer, buffer.Length);

samples/System.Numerics.Tensors.Samples/TensorSamples/Access.cs

@@ -59,19 +59,19 @@ public static void RunSample()
 
         public static unsafe void DumpContentsSparse(CompressedSparseTensor<double> tensor)
         {
-            fixed (double* valuesPtr = &tensor.Values.Span.DangerousGetPinnableReference())
-            fixed (int* compressedCountsPtr = &tensor.CompressedCounts.Span.DangerousGetPinnableReference())
-            fixed (int* indicesPtr = &tensor.Indices.Span.DangerousGetPinnableReference())
-            fixed (int* stridesPtr = &tensor.Strides.DangerousGetPinnableReference())
+            fixed (double* valuesPtr = &MemoryMarshal.GetReference(tensor.Values.Span))
+            fixed (int* compressedCountsPtr = &MemoryMarshal.GetReference(tensor.CompressedCounts.Span))
+            fixed (int* indicesPtr = &MemoryMarshal.GetReference(tensor.Indices.Span))
+            fixed (int* stridesPtr = &MemoryMarshal.GetReference(tensor.Strides))
             {
                 DumpContentsSparse(valuesPtr, compressedCountsPtr, indicesPtr, stridesPtr, tensor.Rank, tensor.NonZeroCount);
             }
         }
 
         public static unsafe void DumpContentsDense(DenseTensor<double> tensor)
         {
-            fixed (double* valuesPtr = &tensor.Buffer.Span.DangerousGetPinnableReference())
-            fixed (int* stridesPtr = &tensor.Strides.DangerousGetPinnableReference())
+            fixed (double* valuesPtr = &MemoryMarshal.GetReference(tensor.Buffer.Span))
+            fixed (int* stridesPtr = &MemoryMarshal.GetReference(tensor.Strides))
             {
                 DumpContentsDense(valuesPtr, stridesPtr, tensor.Rank, (int)tensor.Length);
             }

samples/System.Numerics.Tensors.Samples/TensorSamples/MutateSparse.cs

@@ -33,9 +33,9 @@ public static void RunSample()
 
         public static unsafe double ScalarPowerSparse(CompressedSparseTensor<double> tensor, int exponent)
         {
-            fixed (double* valuesPtr = &tensor.Values.Span.DangerousGetPinnableReference())
-            fixed (int* compressedCountsPtr = &tensor.CompressedCounts.Span.DangerousGetPinnableReference())
-            fixed (int* indicesPtr = &tensor.Indices.Span.DangerousGetPinnableReference())
+            fixed (double* valuesPtr = &MemoryMarshal.GetReference(tensor.Values.Span))
+            fixed (int* compressedCountsPtr = &MemoryMarshal.GetReference(tensor.CompressedCounts.Span))
+            fixed (int* indicesPtr = &MemoryMarshal.GetReference(tensor.Indices.Span))
             {
                 return ScalarPowerSparse(valuesPtr, compressedCountsPtr, indicesPtr, tensor.Dimensions.ToArray(), tensor.Rank, tensor.NonZeroCount, exponent);
             }

samples/System.Numerics.Tensors.Samples/TensorSamples/PreAllocate.cs

@@ -33,7 +33,7 @@ public static unsafe DenseTensor<double> GetMultiplicationTable(int maxNumber)
 
             var result = new DenseTensor<double>(dimensions);
 
-            fixed (double* dataPtr = &result.Buffer.Span.DangerousGetPinnableReference())
+            fixed (double* dataPtr = &MemoryMarshal.GetReference(result.Buffer.Span))
             {
                 GetMultTablePreAllocated(maxNumber, dataPtr, result.Buffer.Length);
             }
@@ -43,7 +43,7 @@ public static unsafe DenseTensor<double> GetMultiplicationTable(int maxNumber)
 
         public static unsafe double GetRowSum(DenseTensor<double> tensor, int row)
         {
-            fixed(double* dataPtr = &tensor.Buffer.Span.DangerousGetPinnableReference())
+            fixed(double* dataPtr = &MemoryMarshal.GetReference(tensor.Buffer.Span))
             {
                 return GetRowSum(dataPtr, tensor.Dimensions.ToArray(), tensor.Rank, row);
             }

samples/System.Numerics.Tensors.Samples/TensorSamples/ReversePInvoke.cs

@@ -41,7 +41,7 @@ public static DenseTensor<double> GetMultiplicationTable(int maxNumber)
 
         public static unsafe double GetRowSum(DenseTensor<double> tensor, int row)
         {
-            fixed(double* dataPtr = &tensor.Buffer.Span.DangerousGetPinnableReference())
+            fixed(double* dataPtr = &MemoryMarshal.GetReference(tensor.Buffer.Span))
             {
                 return GetRowSum(dataPtr, tensor.Dimensions.ToArray(), tensor.Rank, row);
             }

samples/System.Numerics.Tensors.Samples/TensorSamples/WrapNativeMemory.cs

@@ -63,15 +63,15 @@ public static DenseTensor<double> GetMultiplicationTable(int maxNumber)
 
         public static unsafe double GetRowSum(DenseTensor<double> tensor, int row)
         {
-            fixed(double* dataPtr = &tensor.Buffer.Span.DangerousGetPinnableReference())
+            fixed(double* dataPtr = &MemoryMarshal.GetReference(tensor.Buffer.Span))
             {
                 return GetRowSum(dataPtr, tensor.Dimensions.ToArray(), tensor.Rank, row);
             }
         }
 
         public static unsafe void GetMultiplicationTablePreallocated(int maxNumber, DenseTensor<double> tensor)
         {
-            fixed (double* dataPtr = &tensor.Buffer.Span.DangerousGetPinnableReference())
+            fixed (double* dataPtr = &MemoryMarshal.GetReference(tensor.Buffer.Span))
             {
                 GetMultTablePreAllocated(maxNumber, dataPtr, tensor.Buffer.Length);
             }

src/System.Azure.Experimental/System/Azure/Sha256.Windows.cs

@@ -29,7 +29,7 @@ public static Sha256 Create(byte[] seed)
         public int OutputSize => 256 / 8; // Sha256 length in bytes
         public unsafe void Append(ReadOnlySpan<byte> input)
         {
-            fixed (byte* pInput = &input.DangerousGetPinnableReference())
+            fixed (byte* pInput = &MemoryMarshal.GetReference(input))
             {
                 var result = BCryptHashData(_hash, pInput, input.Length, 0);
                 if (result != 0) throw new Exception();
@@ -43,7 +43,7 @@ public bool TryWrite(Span<byte> buffer, out int written, StandardFormat format =
 
             unsafe
             {
-                fixed (byte* pOutput = &buffer.DangerousGetPinnableReference())
+                fixed (byte* pOutput = &MemoryMarshal.GetReference(buffer))
                 {
                     var result = BCryptFinishHash(_hash, pOutput, OutputSize, 0);
                     if (result != 0) throw new Exception();

src/System.Buffers.Experimental/System/Buffers/BufferExtensions.cs

@@ -6,6 +6,7 @@
 using System.Diagnostics;
 using System.Runtime.CompilerServices;
 using System.Numerics;
+using System.Runtime.InteropServices;
 
 namespace System.Buffers
 {
@@ -233,7 +234,7 @@ public static bool TryIndicesOf(this Span<byte> buffer, byte value, Span<int> in
                 return false;
             }
 
-            return TryIndicesOf(ref buffer.DangerousGetPinnableReference(), value, length, indices, out numberOfIndices);
+            return TryIndicesOf(ref MemoryMarshal.GetReference(buffer), value, length, indices, out numberOfIndices);
         }
 
         public static bool TryIndicesOf(this ReadOnlySpan<byte> buffer, byte value, Span<int> indices, out int numberOfIndices)
@@ -245,7 +246,7 @@ public static bool TryIndicesOf(this ReadOnlySpan<byte> buffer, byte value, Span
                 return false;
             }
 
-            return TryIndicesOf(ref buffer.DangerousGetPinnableReference(), value, length, indices, out numberOfIndices);
+            return TryIndicesOf(ref MemoryMarshal.GetReference(buffer), value, length, indices, out numberOfIndices);
         }
 
         private unsafe static bool TryIndicesOf(ref byte searchSpace, byte value, int length, Span<int> indices, out int numberOfIndices)

src/System.Buffers.Experimental/System/Buffers/Text/BufferWriter_sequence.cs

@@ -4,6 +4,7 @@
 
 using System.Diagnostics;
 using System.Runtime.CompilerServices;
+using System.Runtime.InteropServices;
 using System.Text.Utf8;
 
 namespace System.Buffers.Text
@@ -34,7 +35,7 @@ public void WriteBytes(byte[] bytes)
             if (bytes.Length > 0 && free.Length >= bytes.Length)
             {
                 ref byte pSource = ref bytes[0];
-                ref byte pDest = ref free.DangerousGetPinnableReference();
+                ref byte pDest = ref MemoryMarshal.GetReference(free);
 
                 Unsafe.CopyBlockUnaligned(ref pDest, ref pSource, (uint)bytes.Length);
 
@@ -63,7 +64,7 @@ public void WriteBytes(byte[] bytes, int index, int length)
             if (length > 0 && free.Length >= length)
             {
                 ref byte pSource = ref bytes[index];
-                ref byte pDest = ref free.DangerousGetPinnableReference();
+                ref byte pDest = ref MemoryMarshal.GetReference(free);
 
                 Unsafe.CopyBlockUnaligned(ref pDest, ref pSource, (uint)length);
 
@@ -189,7 +190,7 @@ private void WriteBytesChunked(byte[] bytes, int index, int length)
                 var chunkLength = Math.Min(length, free.Length);
 
                 ref byte pSource = ref bytes[index];
-                ref byte pDest = ref free.DangerousGetPinnableReference();
+                ref byte pDest = ref MemoryMarshal.GetReference(free);
 
                 Unsafe.CopyBlockUnaligned(ref pDest, ref pSource, (uint)chunkLength);
 

src/System.IO.Compression.Brotli/System/IO/Compression/Brotli.cs

@@ -3,12 +3,13 @@
 // See the LICENSE file in the project root for more information.
 using System.Buffers;
 using System.IO.Compression.Resources;
+using System.Runtime.InteropServices;
 
 #if BIT64
     using nuint = System.UInt64;
 #else
     using nuint = System.UInt32;
-#endif 
+#endif
 
 namespace System.IO.Compression
 {
@@ -152,8 +153,8 @@ public static OperationStatus FlushEncoder(ReadOnlySpan<byte> source, Span<byte>
             unsafe
             {
                 IntPtr bufIn, bufOut;
-                fixed (byte* inBytes = &source.DangerousGetPinnableReference())
-                fixed (byte* outBytes = &destination.DangerousGetPinnableReference())
+                fixed (byte* inBytes = &MemoryMarshal.GetReference(source))
+                fixed (byte* outBytes = &MemoryMarshal.GetReference(destination))
                 {
                     bufIn = new IntPtr(inBytes);
                     bufOut = new IntPtr(outBytes);
@@ -186,8 +187,8 @@ public static OperationStatus Compress(ReadOnlySpan<byte> source, Span<byte> des
                 IntPtr bufIn, bufOut;
                 while (bytesConsumed > 0)
                 {
-                    fixed (byte* inBytes = &source.DangerousGetPinnableReference())
-                    fixed (byte* outBytes = &destination.DangerousGetPinnableReference())
+                    fixed (byte* inBytes = &MemoryMarshal.GetReference(source))
+                    fixed (byte* outBytes = &MemoryMarshal.GetReference(destination))
                     {
                         bufIn = new IntPtr(inBytes);
                         bufOut = new IntPtr(outBytes);
@@ -218,8 +219,8 @@ public static OperationStatus Decompress(ReadOnlySpan<byte> source, Span<byte> d
             unsafe
             {
                 IntPtr bufIn, bufOut;
-                fixed (byte* inBytes = &source.DangerousGetPinnableReference())
-                fixed (byte* outBytes = &destination.DangerousGetPinnableReference())
+                fixed (byte* inBytes = &MemoryMarshal.GetReference(source))
+                fixed (byte* outBytes = &MemoryMarshal.GetReference(destination))
                 {
                     bufIn = new IntPtr(inBytes);
                     bufOut = new IntPtr(outBytes);

src/System.IO.Pipelines.File/FileReader.cs

@@ -112,7 +112,7 @@ private class ReadOperation
             public unsafe void Read()
             {
                 var buffer = Writer.Alloc(2048);
-                fixed (byte* source = &buffer.Buffer.Span.DangerousGetPinnableReference())
+                fixed (byte* source = &MemoryMarshal.GetReference(buffer.Buffer.Span))
                 {
                     var count = buffer.Buffer.Length;
 

src/System.IO.Pipelines.Text.Primitives/ReadableBufferExtensions.cs

@@ -4,6 +4,7 @@
 using System.Buffers;
 using System.Buffers.Text;
 using System.Runtime.CompilerServices;
+using System.Runtime.InteropServices;
 using System.Text.Parsing;
 using System.Text.Utf8;
 
@@ -133,7 +134,7 @@ public unsafe static string GetAsciiString(this Span<byte> span)
             var asciiString = new string('\0', len);
 
             fixed (char* destination = asciiString)
-            fixed (byte* source = &span.DangerousGetPinnableReference()) {
+            fixed (byte* source = &MemoryMarshal.GetReference(span)) {
                 if (!AsciiUtilities.TryGetAsciiString(source, destination, len)) {
                     ThrowInvalidOperation();
                 }
@@ -167,7 +168,7 @@ public unsafe static string GetAsciiString(this ReadOnlyBuffer buffer)
 
                 foreach (var memory in buffer)
                 {
-                    fixed (byte* source = &memory.Span.DangerousGetPinnableReference())
+                    fixed (byte* source = &MemoryMarshal.GetReference(memory.Span))
                     {
                         if (!AsciiUtilities.TryGetAsciiString(source, output + offset, memory.Length))
                         {

src/System.IO.Pipelines/System/IO/Pipelines/WritableBufferWriter.cs

@@ -3,6 +3,7 @@
 // See the LICENSE file in the project root for more information.
 
 using System.Runtime.CompilerServices;
+using System.Runtime.InteropServices;
 
 namespace System.IO.Pipelines
 {
@@ -31,7 +32,7 @@ public void Write(byte[] source)
             if (source.Length > 0 && _span.Length >= source.Length)
             {
                 ref byte pSource = ref source[0];
-                ref byte pDest = ref _span.DangerousGetPinnableReference();
+                ref byte pDest = ref MemoryMarshal.GetReference(_span);
 
                 Unsafe.CopyBlockUnaligned(ref pDest, ref pSource, (uint)source.Length);
 
@@ -58,7 +59,7 @@ public void Write(byte[] source, int offset, int length)
             if (length > 0 && _span.Length >= length)
             {
                 ref byte pSource = ref source[offset];
-                ref byte pDest = ref _span.DangerousGetPinnableReference();
+                ref byte pDest = ref MemoryMarshal.GetReference(_span);
 
                 Unsafe.CopyBlockUnaligned(ref pDest, ref pSource, (uint)length);
 
@@ -84,7 +85,7 @@ private void WriteMultiBuffer(byte[] source, int offset, int length)
                 var writable = Math.Min(remaining, _span.Length);
 
                 ref byte pSource = ref source[offset];
-                ref byte pDest = ref _span.DangerousGetPinnableReference();
+                ref byte pDest = ref MemoryMarshal.GetReference(_span);
 
                 Unsafe.CopyBlockUnaligned(ref pDest, ref pSource, (uint)writable);
 
@@ -102,4 +103,4 @@ public void Ensure(int count = 1)
             _span = _writableBuffer.Buffer.Span;
         }
     }
-}
+}

src/System.Net.Libuv/System/Net/Libuv/Stream.cs

@@ -87,7 +87,7 @@ public unsafe void TryWrite(ReadOnlySpan<byte> data)
             // This can work with Span<byte> because it's synchronous but we need pinning support
             EnsureNotDisposed();
 
-            fixed (byte* source = &data.DangerousGetPinnableReference())
+            fixed (byte* source = &MemoryMarshal.GetReference(data))
             {
                 var length = data.Length;
 
@@ -109,7 +109,7 @@ public unsafe void TryWrite(ReadOnlyMemory<byte> data)
             // This can work with Span<byte> because it's synchronous but we need pinning support
             EnsureNotDisposed();
 
-            fixed (byte* source = &data.Span.DangerousGetPinnableReference())
+            fixed (byte* source = &MemoryMarshal.GetReference(data.Span))
             {
                 var length = data.Length;
 

src/System.Text.Http.Parser/HttpParser.cs

@@ -6,6 +6,7 @@
 using System.IO.Pipelines;
 using System.Numerics;
 using System.Runtime.CompilerServices;
+using System.Runtime.InteropServices;
 using System.Text.Http.Parser.Internal;
 using Position = System.Buffers.Position;
 
@@ -69,7 +70,7 @@ public unsafe bool ParseRequestLine<T>(T handler, in ReadOnlyBuffer buffer, out
             }
 
             // Fix and parse the span
-            fixed (byte* data = &span.DangerousGetPinnableReference())
+            fixed (byte* data = &MemoryMarshal.GetReference(span))
             {
                 ParseRequestLine(ref handler, data, span.Length);
             }
@@ -102,7 +103,7 @@ public unsafe bool ParseRequestLine<T>(ref T handler, in ReadOnlyBytes buffer, o
             }
 
             // Fix and parse the span
-            fixed (byte* data = &span.DangerousGetPinnableReference())
+            fixed (byte* data = &MemoryMarshal.GetReference(span))
             {
                 ParseRequestLine(ref handler, data, span.Length);
             }
@@ -248,7 +249,7 @@ public unsafe bool ParseHeaders<T>(T handler, in ReadOnlyBuffer buffer, out Posi
                     var span = reader.Span;
                     var remaining = span.Length - reader.Index;
 
-                    fixed (byte* pBuffer = &span.DangerousGetPinnableReference())
+                    fixed (byte* pBuffer = &MemoryMarshal.GetReference(span))
                     {
                         while (remaining > 0)
                         {
@@ -333,7 +334,7 @@ public unsafe bool ParseHeaders<T>(T handler, in ReadOnlyBuffer buffer, out Posi
                                 var headerSpan = buffer.Slice(current, lineEnd).ToSpan();
                                 length = headerSpan.Length;
 
-                                fixed (byte* pHeader = &headerSpan.DangerousGetPinnableReference())
+                                fixed (byte* pHeader = &MemoryMarshal.GetReference(headerSpan))
                                 {
                                     TakeSingleHeader(pHeader, length, ref handler);
                                 }
@@ -381,7 +382,7 @@ public unsafe bool ParseHeaders<T>(ref T handler, ReadOnlyBytes buffer, out int
 
             while (true)
             {
-                fixed (byte* pBuffer = &currentSpan.DangerousGetPinnableReference())
+                fixed (byte* pBuffer = &MemoryMarshal.GetReference(currentSpan))
                 {
                     while (remaining > 0)
                     {
@@ -449,7 +450,7 @@ public unsafe bool ParseHeaders<T>(ref T handler, ReadOnlyBytes buffer, out int
                             var headerSpan = buffer.Slice(index, end - index + 1).ToSpan();
                             length = headerSpan.Length;
 
-                            fixed (byte* pHeader = &headerSpan.DangerousGetPinnableReference())
+                            fixed (byte* pHeader = &MemoryMarshal.GetReference(headerSpan))
                             {
                                 TakeSingleHeader(pHeader, length, ref handler);
                             }