Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Remove git setup from Nano job. #7413

Merged
merged 2 commits into from
Mar 31, 2016
Merged

Remove git setup from Nano job. #7413

merged 2 commits into from
Mar 31, 2016

Conversation

Priya91
Copy link
Contributor

@Priya91 Priya91 commented Mar 31, 2016

@Priya91
Copy link
Contributor Author

Priya91 commented Mar 31, 2016

@dotnet-bot test ci please

@Priya91
Copy link
Contributor Author

Priya91 commented Mar 31, 2016

@mmitche the generator is failing at addPrivatePermissions that no such method exists.. This was added in this PR #7395

How to fix this? Is this because corefx is using an older dotnet-ci generator definition..

@Priya91
Copy link
Contributor Author

Priya91 commented Mar 31, 2016

@dotnet-bot test ci please

Retrigged dotnet-ci generator run, retrigger ci run here

@Priya91
Copy link
Contributor Author

Priya91 commented Mar 31, 2016

@dotnet-bot test ci please

@Priya91 Priya91 merged commit c37dd98 into dotnet:master Mar 31, 2016
@Priya91 Priya91 deleted the netci branch March 31, 2016 21:47
@mmitche
Copy link
Member

mmitche commented Apr 1, 2016

@Priya91 Looks like this exposed a bug in the pull request builder (maybe, might be something else). That is keeping projects from launching PRs. I'm going to revert this for until tomorrow morning when I can figure out what's going on.

@Priya91
Copy link
Contributor Author

Priya91 commented Apr 1, 2016

@mmitche this is very specific to Nano job. Can't think of how this can affect other jobs.. Also Nano jobs fail without this. I think i can set the OS for the flow job to Windows_NT, instead of Nano, then the git issue will not be there. will try it out, with it, i may not need this change at all.

#7413 (comment)

@mmitche
Copy link
Member

mmitche commented Apr 4, 2016

@Priya It's because of the way the plugin is written. The lack of a github address in the job was causing the PR trigger to initialize improperly (throwing an error that there was no github address). However it was blocking other PRs from starting.

You are right about setting the affinity of the flow job though. That should work.

@karelz karelz modified the milestone: 1.0.0-rtm Dec 3, 2016
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Remove git setup from Nano job.

Commit migrated from dotnet/corefx@c37dd98
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants