Add new System.Net.Http.Json project/namespace #42889
Conversation
|
Could you also add this package to the package list in packages.builds so that it gets built? Lines 21 to 29 in 5251f9c |
|
CI failure reason is that tests using |
|
Yup, I just moved them to the netcoreapp-specific configuration |
| <Project DefaultTargets="Build"> | ||
| <Import Project="$([MSBuild]::GetPathOfFileAbove(Directory.Build.props))" /> | ||
| <ItemGroup> | ||
| <ProjectReference Include="..\ref\System.Net.Http.Json.csproj"> |
There was a problem hiding this comment.
We should omit the ref unless we have a good reason to have it.
There was a problem hiding this comment.
Our model until release/3.1 has been to always have the ref unless it causes issues (like hiding dependencies to RAR when targetting desktop) which this package isn't doing, so in my point of view it would be better to not special-case it and keep it consistent unless we think it would hurt. That said, I'm totally open for suggestions here so I can remove it too if you think we should.
There was a problem hiding this comment.
We previously did a pass to try to limit the number of places where we expose refs to desktop. System.Text.Json, for example, does not expose a reference assembly. All new packages we try not to include refs unless we must have them for some reason.
| <Project> | ||
| <PropertyGroup> | ||
| <BuildConfigurations> | ||
| netstandard; |
There was a problem hiding this comment.
should we also have a net461 configuration?
There was a problem hiding this comment.
We could add a net461 config, but that would still mean we will need the facades here, since we depend on SYstem.Text.Json which will pull them in. I was planning on adding net461 config here with my configuration changes wave comming next so that we have one PR doing it for every package that needs it. If you still think I should add it here now, I can do that too.
There was a problem hiding this comment.
Go ahead and do it now. I think the timing of the next wave will land before we stabalize this, so I'd prefer to have this done WRT coding and just need to pick up package dependency updates when we ship those.
There was a problem hiding this comment.
(assuming this is a small task, if anything gets complicated we can postpone this until after the first preview)
|
Seems like OSX Helix machines are hanging which is keeping the OSX leg running. The idea is to merge this in soon in order to start working on making sure the official build of this branch is working as expected. If there isn't more feedback I would love to merge this now to work on the official build and then put up a new PR here addressing any new feedback that comes up. |
joperezr
force-pushed
the
3.1-blazor/HttpJson
branch
from
d04e772
to
799aa67
Compare
| @@ -1,10 +1,13 @@ | |||
| <Project DefaultTargets="Build"> | |||
| <Import Project="$([MSBuild]::GetPathOfFileAbove(Directory.Build.props))" /> | |||
| <ItemGroup> | |||
| <ProjectReference Include="..\ref\System.Net.Http.Json.csproj"> | |||
| <SupportedFramework>net461;netcoreapp2.0;uap10.0.16299;$(AllXamarinFrameworks)</SupportedFramework> | |||
| <ProjectReference Include="..\ref\System.Net.Http.Json.csproj" /> | |||
There was a problem hiding this comment.
You should just omit the projectreference to ref.
|
Osx test failure is unrelated to this pr so I’ll go ahead and merge this. |
Porting #42879 to new blazor branch. The 3.1 PR was already approved for servicing. It includes all commits from PR dotnet/runtime#33459 up to dotnet/runtime@4970a53
cc: @ericstj @jozkee @jeffhandley @stephentoub @terrajobst @mkArtakMSFT @safern @GrabYourPitchforks