This repository was archived by the owner on Jan 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Add Semaphore creation extension methods that take an ACL #42377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pending adding unit tests. |
danmoseley
reviewed
Nov 5, 2019
src/System.Threading.AccessControl/src/System/Threading/SemaphoreAcl.cs
Outdated
Show resolved
Hide resolved
src/System.Threading.AccessControl/src/System/Threading/SemaphoreAcl.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Nov 5, 2019
src/System.Threading.AccessControl/ref/System.Threading.AccessControl.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Nov 5, 2019
src/System.Threading.AccessControl/src/System/Threading/SemaphoreAcl.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Nov 5, 2019
stephentoub
reviewed
Nov 5, 2019
stephentoub
reviewed
Nov 5, 2019
stephentoub
reviewed
Nov 5, 2019
stephentoub
reviewed
Nov 5, 2019
stephentoub
reviewed
Nov 5, 2019
src/System.Threading.AccessControl/src/System/Threading/SemaphoreAcl.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Nov 5, 2019
src/System.Threading.AccessControl/src/System/Threading/SemaphoreAcl.cs
Outdated
Show resolved
Hide resolved
…aders, nit suggestions.
Thank you for your contribution. As announced in dotnet/coreclr#27549 this repository will be moving to dotnet/runtime on November 13. If you would like to continue working on this PR after this date, the easiest way to move the change to dotnet/runtime is:
|
stephentoub
approved these changes
Nov 7, 2019
JeremyKuhne
approved these changes
Nov 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thank you for your signoffs! I resolved the conflicts with master, will wait for the CI to finish, and then will merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approved API Proposal: https://github.com/dotnet/corefx/issues/41662
Related PR for EventWaitHandle: #42213
Related PR for Mutex: #42281
Description
We don't currently have a way to create a Semaphore with a given ACL in .NET Core. We can modify the ACL, but it would be more secure to have the proper ACL on the object from the start.
Customer impact
Before this change, customers had to create a Semaphore, then set its ACLs. This presents a few problems:
This change addresses those problems by adding a new extension method that allows creating a Semaphore and ensuring the provided ACLs are set during creation.
We will try to merge this to 3.1 if time permits it.