Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

@Anipik
Copy link

@Anipik Anipik commented Sep 30, 2019

No description provided.

@ericstj
Copy link
Member

ericstj commented Sep 30, 2019

@joperezr this is triggering the check you added for harvesting. I think we can disable that check for this package

D:\a\1\s\.packages\microsoft.dotnet.build.tasks.packaging\1.0.0-beta.19474.3\build\Packaging.targets(425,5): error : Cannot locate package 'runtime.native.System.IO.Ports' version '4.6.0' under 'D:\a\1\s\.packages'.  Harvesting is needed to redistribute assets and ensure compatibility with the previous release.  You can disable this by setting HarvestStablePackage=false. [D:\a\1\s\pkg\runtime.native.System.IO.Ports\runtime.native.System.IO.Ports.pkgproj]
##[error].packages\microsoft.dotnet.build.tasks.packaging\1.0.0-beta.19474.3\build\Packaging.targets(425,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Cannot locate package 'runtime.native.System.IO.Ports' version '4.6.0' under 'D:\a\1\s\.packages'.  Harvesting is needed to redistribute assets and ensure compatibility with the previous release.  You can disable this by setting HarvestStablePackage=false.
  Verifying closure of Microsoft.Private.CoreFx.NETCoreApp reference assemblies

I'd fix this by making the setting HarvestStablePackage=false in https://github.com/dotnet/corefx/blob/master/pkg/Directory.Build.props.

Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Merge at will

@Anipik Anipik merged commit 1551404 into dotnet:release/3.1 Oct 1, 2019
@Anipik Anipik deleted the enable branch October 1, 2019 17:23
@karelz karelz added this to the 3.1 milestone Dec 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants