This repository was archived by the owner on Jan 23, 2023. It is now read-only.
SqlClient minor memory improvements #34134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used cleanup ContinueWith calls to pass state parameterswhere doing so is trivial or advantageous
saurabh500
approved these changes
Jan 8, 2019
saurabh500
reviewed
Jan 8, 2019
src/System.Data.SqlClient/src/System/Data/SqlClient/TdsParser.cs
Outdated
Show resolved
Hide resolved
saurabh500
reviewed
Jan 8, 2019
saurabh500
reviewed
Jan 8, 2019
src/System.Data.SqlClient/src/System/Data/SqlClient/TdsParserStateObject.cs
Outdated
Show resolved
Hide resolved
saurabh500
reviewed
Jan 8, 2019
Contributor
saurabh500
left a comment
saurabh500
left a comment
There was a problem hiding this comment.
Overall looks good to me. Left some Nit: comments.
Contributor
Author
|
@dotnet-bot test Windows x86 Release Build please |
Contributor
|
@Wraith2 There are some merge conflicts now. Can you take care of this? |
Contributor
Author
|
Done. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
SqlClient minor memory improvements Commit migrated from dotnet/corefx@abd0482
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some work was done in #34047 to limit allocation of closures and move to explicit state passing for continuations. This PR continues/finishes that work and cleans up some of the async code to be more readable.
AsyncHelper had a few methods which took unused parameters, either internal or external connections, with names that indicated those connections were going to be closed. The parameters were never used. I judged these to be dead code and eliminated the parameters and all call sites using them.
the function ContinueTaskPend was removed as dead code with no callers.
I recommend looking at the changes side by side, the inline diff makes them look confusing
/cc @saurabh500 @afsanehr @keeratsingh