This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
QueryDirectoryFile requires 64 bit alignment to work on ARM32. #33713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Marshal.AllocHGlobal instead of byte[] will do that (and avoid the need to pin).
stephentoub
reviewed
Nov 27, 2018
src/System.IO.FileSystem/src/System/IO/Enumeration/FileSystemEnumerator.Windows.cs
Show resolved
Hide resolved
stephentoub
reviewed
Nov 27, 2018
src/System.IO.FileSystem/src/System/IO/Enumeration/FileSystemEnumerator.Windows.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Nov 27, 2018
src/System.IO.FileSystem/src/System/IO/Enumeration/FileSystemEnumerator.Windows.cs
Show resolved
Hide resolved
stephentoub
approved these changes
Nov 27, 2018
jkotas
approved these changes
Nov 27, 2018
|
Were you able to get a repro environment after chatting with me? |
I have the hardware now, I'll be working on getting it set up today. |
|
Approved for 2.2.1 |
|
Validated the fix for 3.0 on the latest IOT. |
JeremyKuhne
added a commit
to JeremyKuhne/corefx
that referenced
this pull request
Nov 30, 2018
…t#33713) * QueryDirectoryFile requires 64 bit alignment to work on ARM32. Using Marshal.AllocHGlobal instead of byte[] will do that (and avoid the need to pin). * Address feedback.
JeremyKuhne
added a commit
that referenced
this pull request
Nov 30, 2018
… (#33754) * QueryDirectoryFile requires 64 bit alignment to work on ARM32. Using Marshal.AllocHGlobal instead of byte[] will do that (and avoid the need to pin). * Address feedback.
jlennox
pushed a commit
to jlennox/corefx
that referenced
this pull request
Dec 16, 2018
…t#33713) * QueryDirectoryFile requires 64 bit alignment to work on ARM32. Using Marshal.AllocHGlobal instead of byte[] will do that (and avoid the need to pin). * Address feedback.
|
@vivmishra removing Servicing-approved & milestone -- this was PR against master. The servicing version was approved in PR #33754 |
tommcdon
pushed a commit
that referenced
this pull request
Sep 20, 2019
… (#41217) * QueryDirectoryFile requires 64 bit alignment to work on ARM32. Using Marshal.AllocHGlobal instead of byte[] will do that (and avoid the need to pin). * Address feedback.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…t/corefx#33713) * QueryDirectoryFile requires 64 bit alignment to work on ARM32. Using Marshal.AllocHGlobal instead of byte[] will do that (and avoid the need to pin). * Address feedback. Commit migrated from dotnet/corefx@a75f96a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Marshal.AllocHGlobal instead of byte[] will do that (and avoid the need to pin).
Should fix #33563, still setting up hardware to validate. Putting this up to validate other environments and get the approach validated.
cc: @danmosemsft, @joperezr, @joshfree