This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Adding some basic Utf8Formatter/Utf8Parser perf tests covering decimal, double, and float #33427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l, double, and float
stephentoub
reviewed
Nov 12, 2018
| [InlineData(2.71828182845904524)] // Positive e | ||
| [InlineData(3.14159265358979324)] // Positive pi | ||
| [InlineData(double.MaxValue)] // Max Positive Normal | ||
| [InlineData(double.PositiveInfinity)] // Positive Infinity |
There was a problem hiding this comment.
Do all of these have sufficiently different code paths / specializations that they're all worth running? I think @adamsitnik was trying to cull the number of variations for a given perf test down to some small set, but I don't know exactly what the criteria he was using was. Maybe we need to split things inner/outer loop, or something like that.
There was a problem hiding this comment.
Yes. This is covering each of the special input kinds for floating-point numbers:
- Zero (positive and negative)
- Infinity
- NaN
- Normal
- Subnormal
For the categories, we are then testing specific numbers that are known to be handled differently (either because they produce/consume additional digits, or they fall outside the normal input range and hit the slow path).
stephentoub
approved these changes
Nov 12, 2018
jlennox
pushed a commit
to jlennox/corefx
that referenced
this pull request
Dec 16, 2018
…l, double, and float (dotnet#33427) * Adding some basic Utf8Formatter/Utf8Parser perf tests covering decimal, double, and float * Changing the inner iteration count to use the `InnerCount` constant
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…l, double, and float (dotnet/corefx#33427) * Adding some basic Utf8Formatter/Utf8Parser perf tests covering decimal, double, and float * Changing the inner iteration count to use the `InnerCount` constant Commit migrated from dotnet/corefx@811e41a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC. @stephentoub, @GrabYourPitchforks
These just mirror the Utf16Parser/Utf16Formatter perf tests for these types.