Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

SqlClient memory performance changes #32811

Closed
Wraith2 wants to merge 16 commits into from
Closed

SqlClient memory performance changes #32811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
6e7e44b
rpc rework
Wraith2 Oct 12, 2018
c0c8a7f
Merge remote-tracking branch 'dotnet/master' into sqlperf
Wraith2 Oct 13, 2018
63ff136
hoisted async lamda allocating functions to avoid allocating on synch…
Wraith2 Oct 13, 2018
cb84ce0
spanify write single and double
Wraith2 Oct 13, 2018
8af254f
change prepare dhandle storage to use box and cache statis prepared i…
Wraith2 Oct 14, 2018
b4e92b0
comment cleanup and formatting fixes
Wraith2 Oct 17, 2018
130491d
ifdefed float and double span writes to netcoreapp only
Wraith2 Oct 18, 2018
ec4bc00
limit copy source span to len in case b.Length>len
Wraith2 Oct 19, 2018
7304e3a
Merge remote-tracking branch 'dotnet/master' into sqlperf
Wraith2 Oct 23, 2018
ff7f156
clarify copy source length and add length check assertions
Wraith2 Oct 24, 2018
3374f56
seal async state and try to avoid creating it unless it is needed
Wraith2 Oct 25, 2018
8af8d3a
remove unused code comment
Wraith2 Oct 25, 2018
8744a67
correct multipacket slice in loop
Wraith2 Oct 25, 2018
04cf258
address feedback
Wraith2 Oct 26, 2018
2c459d2
address feedback to cleanup spacing
Wraith2 Oct 31, 2018
869208d
rename WriteByteArray to WriteBytes, add comment explaining params, m…
Wraith2 Nov 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
304 changes: 173 additions & 131 deletions src/System.Data.SqlClient/src/System/Data/SqlClient/SqlCommand.cs
View file
Open in desktop

Large diffs are not rendered by default.

10 changes: 9 additions & 1 deletion src/System.Data.SqlClient/src/System/Data/SqlClient/SqlConnection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
using System.IO;
using System.Globalization;
using System.Security;
using System.Runtime.CompilerServices;

namespace System.Data.SqlClient
{
Expand Down Expand Up @@ -911,7 +912,7 @@ internal Task ValidateAndReconnect(Action beforeDisconnect, int timeout)
catch (SqlException)
{
}
runningReconnect = Task.Run(() => ReconnectAsync(timeout));
runningReconnect = ValidateAndReconnectSetupReconnectContinuation(timeout);
// if current reconnect is not null, somebody already started reconnection task - some kind of race condition
Debug.Assert(_currentReconnectionTask == null, "Duplicate reconnection tasks detected");
_currentReconnectionTask = runningReconnect;
Expand Down Expand Up @@ -949,6 +950,13 @@ internal Task ValidateAndReconnect(Action beforeDisconnect, int timeout)
return runningReconnect;
}

// This is in its own method to avoid always allocating the lambda in ValidateAndReconnect
[MethodImpl(MethodImplOptions.NoInlining)]
private Task ValidateAndReconnectSetupReconnectContinuation(int timeout)
{
return Task.Run(() => ReconnectAsync(timeout));
}

// this is straightforward, but expensive method to do connection resiliency - it take locks and all preparations as for TDS request
partial void RepairInnerConnection()
{
Expand Down
Loading