Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Implement System.ComponentModel.VersionConverter #28516

Merged
merged 6 commits into from
Aug 17, 2018
Merged

Implement System.ComponentModel.VersionConverter #28516

merged 6 commits into from
Aug 17, 2018

Commits on Aug 16, 2018

  1. Implement System.ComponentModel.VersionConverter 

    VersionConverter is a new System.ComponentModel.TypeConverter subclass that handle conversions between string and System.Version.
    @0xced
    0xced committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    0256728 View commit details
    Browse the repository at this point in the history

  2. Fix tests build for VersionTypeConverter

    @stephentoub @0xced
    stephentoub authored and 0xced committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    a844602 View commit details
    Browse the repository at this point in the history

  3. Use Version.Parse() instead of new Version() to save an allocation

    @0xced
    0xced committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    09fe984 View commit details
    Browse the repository at this point in the history

  4. Add test data to ensure that the version string is trimmed

    @0xced
    0xced committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    10cdee3 View commit details
    Browse the repository at this point in the history

  5. Call base class implementation instead of explicitly throwing

    @0xced
    0xced committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    2ba1f61 View commit details
    Browse the repository at this point in the history

  6. Always throw a FormatException when a version string is invalid

    @0xced
    0xced committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    004ef11 View commit details
    Browse the repository at this point in the history