Enable RHEL6 in release/2.0.0 #23084
Conversation
Enable RHEL6 in release/2.0.0
buildpipeline/pipeline.json
Outdated
| @@ -21,7 +21,7 @@ | |||
| "PB_BuildArguments": "-buildArch=x64 -Release -stripSymbols", | |||
| "PB_BuildTestsArguments": "-buildArch=x64 -Release -SkipTests -Outerloop -- /p:ArchiveTests=true /p:EnableDumpling=true", | |||
| "PB_SyncArguments": "-p -- /p:ArchGroup=x64", | |||
| "PB_TargetQueue": "Centos.73.Amd64+RedHat.72.Amd64+RedHat.73.Amd64+Debian.87.Amd64+Debian.90.Amd64+Ubuntu.1404.Amd64+Ubuntu.1604.Amd64+Ubuntu.1704.Amd64+suse.422.amd64+SLES.12.Amd64+fedora.25.amd64+Fedora.26.Amd64", | |||
| "PB_TargetQueue": "Centos.73.Amd64+RedHat.69.Amd64+RedHat.72.Amd64+RedHat.73.Amd64+Debian.87.Amd64+Debian.90.Amd64+Ubuntu.1404.Amd64+Ubuntu.1604.Amd64+Ubuntu.1704.Amd64+suse.422.amd64+SLES.12.Amd64+fedora.25.amd64+Fedora.26.Amd64", | |||
There was a problem hiding this comment.
We need to actually build on RH6 not test our portable build on RH6. So you will need to copy the definition for linux and pass in the RH6 docker tag for it.
There was a problem hiding this comment.
Thanks Wes. I've removed RHEL6 queue from portable build list, and added a new entry for it to use build from docker build instead of portable build.
Make RHEL6 runs use build from docker, instead of portable build
|
Thanks @weshaggard for the review, can you take a second look? |
Change it to a better name.
buildpipeline/pipeline.json
Outdated
| @@ -45,6 +45,23 @@ | |||
| "Type": "build/product/", | |||
| "ConfigurationGroup": "Release" | |||
| } | |||
| }, | |||
| { | |||
| "Name": "DotNet-CoreFx-Trusted-Linux-RedHat6", | |||
There was a problem hiding this comment.
I think this name needs to match the build definition name so it should be "Dotnet-CoreFx-Trusted-Linux", same with the other one.
There was a problem hiding this comment.
Thanks @weshaggard . Got your point, same BD name, but different docker and queue name for RHEL6. Changed as you suggested.
…her Linux runs. Make sure RedHat6 runs still use the same build definition name as other Linux runs.
|
Thanks @weshaggard . I've sent out the Email for ShipRoom approval. Once it's approved, I will merge it to test it out. In the meanwhile i'm working on the changes in corefx master (which need CI changes), and the changes in master/release2.0.0 of both coreclr and core-setup. |
…3084) * Use platform specific implementation of GetCurrentProcessId directly in shared location instead of relying on runtime export * Move GetCurrentProcessId to Interop class * Update ES_BUILD_STANDALONE build Signed-off-by: dotnet-bot <[email protected]>
* Use platform specific implementation of GetCurrentProcessId directly in shared location instead of relying on runtime export * Move GetCurrentProcessId to Interop class * Update ES_BUILD_STANDALONE build Signed-off-by: dotnet-bot <[email protected]>
Enable RHEL6 in release/2.0.0